diff options
| author | Daniel Axtens <dja@axtens.net> | 2019-06-27 01:30:08 -0400 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2019-08-22 09:12:48 -0400 |
| commit | 7e04a46d84f73ef0f21d2257d6ba2a194c0f1511 (patch) | |
| tree | fcd8106a218f3803ed52e2d15df8fc33faf4724c | |
| parent | b8baa05a0e505f8311fb03f5c72e75fa0e13fd95 (diff) | |
powerpc/configs: Disable /dev/port in skiroot defconfig
While reviewing lockdown patches, I discovered that we still enable
/dev/port (CONFIG_DEVPORT) in skiroot.
/dev/port is used for old x86 style IO accesses. It's set up in
drivers/char/mem.c, and is only created if arch_has_dev_port() returns
true. Per arch/powerpc/include/asm/io.h, on PPC64 with PCI, this is
only true if there's a legacy ISA bridge.
Even if a system has a legacy ISA bridge installed, we have no
business accessing it in skiroot.
Deselect CONFIG_DEVPORT for skiroot.
Signed-off-by: Daniel Axtens <dja@axtens.net>
[mpe: Incorporate emailed comments into the change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190627053008.29315-1-dja@axtens.net
| -rw-r--r-- | arch/powerpc/configs/skiroot_defconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig index 557b530b2f70..1253482a67c0 100644 --- a/arch/powerpc/configs/skiroot_defconfig +++ b/arch/powerpc/configs/skiroot_defconfig | |||
| @@ -213,6 +213,7 @@ CONFIG_IPMI_WATCHDOG=y | |||
| 213 | CONFIG_HW_RANDOM=y | 213 | CONFIG_HW_RANDOM=y |
| 214 | CONFIG_TCG_TPM=y | 214 | CONFIG_TCG_TPM=y |
| 215 | CONFIG_TCG_TIS_I2C_NUVOTON=y | 215 | CONFIG_TCG_TIS_I2C_NUVOTON=y |
| 216 | # CONFIG_DEVPORT is not set | ||
| 216 | CONFIG_I2C=y | 217 | CONFIG_I2C=y |
| 217 | # CONFIG_I2C_COMPAT is not set | 218 | # CONFIG_I2C_COMPAT is not set |
| 218 | CONFIG_I2C_CHARDEV=y | 219 | CONFIG_I2C_CHARDEV=y |