diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-03-16 22:01:08 -0400 |
|---|---|---|
| committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-03-16 23:56:31 -0400 |
| commit | 7cbbbb8bc2974264bbbf326d9a4552fc8878d375 (patch) | |
| tree | f5a3c927cd662dc9fac451335097de0205d6f087 | |
| parent | f84dde10d893cd368e73dda04b694169542ed792 (diff) | |
kbuild: warn redundant generic-y
The generic-y is redundant under the following condition:
- arch has its own implementation
- the same header is added to generated-y
- the same header is added to mandatory-y
If a redundant generic-y is found, the warning like follows is displayed:
scripts/Makefile.asm-generic:20: redundant generic-y found in arch/arm/include/asm/Kbuild: timex.h
I fixed up arch Kbuild files found by this.
Suggested-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
| -rw-r--r-- | arch/arm/include/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/h8300/include/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/ia64/include/uapi/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/openrisc/include/asm/Kbuild | 2 | ||||
| -rw-r--r-- | arch/parisc/include/asm/Kbuild | 2 | ||||
| -rw-r--r-- | arch/powerpc/include/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/s390/include/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/s390/include/uapi/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/x86/include/uapi/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/xtensa/include/asm/Kbuild | 1 | ||||
| -rw-r--r-- | arch/xtensa/include/uapi/asm/Kbuild | 1 | ||||
| -rw-r--r-- | scripts/Makefile.asm-generic | 6 |
12 files changed, 6 insertions, 13 deletions
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild index 1d66db9c9db5..a8a4eb7f6dae 100644 --- a/arch/arm/include/asm/Kbuild +++ b/arch/arm/include/asm/Kbuild | |||
| @@ -18,7 +18,6 @@ generic-y += segment.h | |||
| 18 | generic-y += serial.h | 18 | generic-y += serial.h |
| 19 | generic-y += simd.h | 19 | generic-y += simd.h |
| 20 | generic-y += sizes.h | 20 | generic-y += sizes.h |
| 21 | generic-y += timex.h | ||
| 22 | generic-y += trace_clock.h | 21 | generic-y += trace_clock.h |
| 23 | 22 | ||
| 24 | generated-y += mach-types.h | 23 | generated-y += mach-types.h |
diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild index 961c1dc064e1..3e7c8ecf151e 100644 --- a/arch/h8300/include/asm/Kbuild +++ b/arch/h8300/include/asm/Kbuild | |||
| @@ -17,7 +17,6 @@ generic-y += fb.h | |||
| 17 | generic-y += ftrace.h | 17 | generic-y += ftrace.h |
| 18 | generic-y += futex.h | 18 | generic-y += futex.h |
| 19 | generic-y += hardirq.h | 19 | generic-y += hardirq.h |
| 20 | generic-y += hash.h | ||
| 21 | generic-y += hw_irq.h | 20 | generic-y += hw_irq.h |
| 22 | generic-y += irq_regs.h | 21 | generic-y += irq_regs.h |
| 23 | generic-y += irq_work.h | 22 | generic-y += irq_work.h |
diff --git a/arch/ia64/include/uapi/asm/Kbuild b/arch/ia64/include/uapi/asm/Kbuild index b71c5f787783..5b819e53c397 100644 --- a/arch/ia64/include/uapi/asm/Kbuild +++ b/arch/ia64/include/uapi/asm/Kbuild | |||
| @@ -2,4 +2,3 @@ include include/uapi/asm-generic/Kbuild.asm | |||
| 2 | 2 | ||
| 3 | generated-y += unistd_64.h | 3 | generated-y += unistd_64.h |
| 4 | generic-y += kvm_para.h | 4 | generic-y += kvm_para.h |
| 5 | generic-y += socket.h | ||
diff --git a/arch/openrisc/include/asm/Kbuild b/arch/openrisc/include/asm/Kbuild index 1f04844b6b82..5a73e2956ac4 100644 --- a/arch/openrisc/include/asm/Kbuild +++ b/arch/openrisc/include/asm/Kbuild | |||
| @@ -15,7 +15,6 @@ generic-y += fb.h | |||
| 15 | generic-y += ftrace.h | 15 | generic-y += ftrace.h |
| 16 | generic-y += hardirq.h | 16 | generic-y += hardirq.h |
| 17 | generic-y += hw_irq.h | 17 | generic-y += hw_irq.h |
| 18 | generic-y += irq.h | ||
| 19 | generic-y += irq_regs.h | 18 | generic-y += irq_regs.h |
| 20 | generic-y += irq_work.h | 19 | generic-y += irq_work.h |
| 21 | generic-y += kdebug.h | 20 | generic-y += kdebug.h |
| @@ -35,7 +34,6 @@ generic-y += qrwlock.h | |||
| 35 | generic-y += sections.h | 34 | generic-y += sections.h |
| 36 | generic-y += segment.h | 35 | generic-y += segment.h |
| 37 | generic-y += shmparam.h | 36 | generic-y += shmparam.h |
| 38 | generic-y += string.h | ||
| 39 | generic-y += switch_to.h | 37 | generic-y += switch_to.h |
| 40 | generic-y += topology.h | 38 | generic-y += topology.h |
| 41 | generic-y += trace_clock.h | 39 | generic-y += trace_clock.h |
diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild index 0b1e354c8c24..6f49e77d82a2 100644 --- a/arch/parisc/include/asm/Kbuild +++ b/arch/parisc/include/asm/Kbuild | |||
| @@ -1,7 +1,6 @@ | |||
| 1 | generated-y += syscall_table_32.h | 1 | generated-y += syscall_table_32.h |
| 2 | generated-y += syscall_table_64.h | 2 | generated-y += syscall_table_64.h |
| 3 | generated-y += syscall_table_c32.h | 3 | generated-y += syscall_table_c32.h |
| 4 | generic-y += barrier.h | ||
| 5 | generic-y += current.h | 4 | generic-y += current.h |
| 6 | generic-y += device.h | 5 | generic-y += device.h |
| 7 | generic-y += div64.h | 6 | generic-y += div64.h |
| @@ -20,7 +19,6 @@ generic-y += percpu.h | |||
| 20 | generic-y += preempt.h | 19 | generic-y += preempt.h |
| 21 | generic-y += seccomp.h | 20 | generic-y += seccomp.h |
| 22 | generic-y += segment.h | 21 | generic-y += segment.h |
| 23 | generic-y += topology.h | ||
| 24 | generic-y += trace_clock.h | 22 | generic-y += trace_clock.h |
| 25 | generic-y += user.h | 23 | generic-y += user.h |
| 26 | generic-y += vga.h | 24 | generic-y += vga.h |
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild index 77ff7fb24823..a0c132bedfae 100644 --- a/arch/powerpc/include/asm/Kbuild +++ b/arch/powerpc/include/asm/Kbuild | |||
| @@ -5,7 +5,6 @@ generated-y += syscall_table_spu.h | |||
| 5 | generic-y += div64.h | 5 | generic-y += div64.h |
| 6 | generic-y += export.h | 6 | generic-y += export.h |
| 7 | generic-y += irq_regs.h | 7 | generic-y += irq_regs.h |
| 8 | generic-y += irq_work.h | ||
| 9 | generic-y += local64.h | 8 | generic-y += local64.h |
| 10 | generic-y += mcs_spinlock.h | 9 | generic-y += mcs_spinlock.h |
| 11 | generic-y += preempt.h | 10 | generic-y += preempt.h |
diff --git a/arch/s390/include/asm/Kbuild b/arch/s390/include/asm/Kbuild index e3239772887a..12d77cb11fe5 100644 --- a/arch/s390/include/asm/Kbuild +++ b/arch/s390/include/asm/Kbuild | |||
| @@ -20,7 +20,6 @@ generic-y += local.h | |||
| 20 | generic-y += local64.h | 20 | generic-y += local64.h |
| 21 | generic-y += mcs_spinlock.h | 21 | generic-y += mcs_spinlock.h |
| 22 | generic-y += mm-arch-hooks.h | 22 | generic-y += mm-arch-hooks.h |
| 23 | generic-y += preempt.h | ||
| 24 | generic-y += rwsem.h | 23 | generic-y += rwsem.h |
| 25 | generic-y += trace_clock.h | 24 | generic-y += trace_clock.h |
| 26 | generic-y += unaligned.h | 25 | generic-y += unaligned.h |
diff --git a/arch/s390/include/uapi/asm/Kbuild b/arch/s390/include/uapi/asm/Kbuild index 6b0f30b14642..da3e0d48abbc 100644 --- a/arch/s390/include/uapi/asm/Kbuild +++ b/arch/s390/include/uapi/asm/Kbuild | |||
| @@ -3,4 +3,3 @@ include include/uapi/asm-generic/Kbuild.asm | |||
| 3 | 3 | ||
| 4 | generated-y += unistd_32.h | 4 | generated-y += unistd_32.h |
| 5 | generated-y += unistd_64.h | 5 | generated-y += unistd_64.h |
| 6 | generic-y += socket.h | ||
diff --git a/arch/x86/include/uapi/asm/Kbuild b/arch/x86/include/uapi/asm/Kbuild index efe701b7c6ce..f6648e9928b3 100644 --- a/arch/x86/include/uapi/asm/Kbuild +++ b/arch/x86/include/uapi/asm/Kbuild | |||
| @@ -3,4 +3,3 @@ include include/uapi/asm-generic/Kbuild.asm | |||
| 3 | generated-y += unistd_32.h | 3 | generated-y += unistd_32.h |
| 4 | generated-y += unistd_64.h | 4 | generated-y += unistd_64.h |
| 5 | generated-y += unistd_x32.h | 5 | generated-y += unistd_x32.h |
| 6 | generic-y += socket.h | ||
diff --git a/arch/xtensa/include/asm/Kbuild b/arch/xtensa/include/asm/Kbuild index d939e13e8d84..42b6cb3d16f7 100644 --- a/arch/xtensa/include/asm/Kbuild +++ b/arch/xtensa/include/asm/Kbuild | |||
| @@ -15,7 +15,6 @@ generic-y += irq_work.h | |||
| 15 | generic-y += kdebug.h | 15 | generic-y += kdebug.h |
| 16 | generic-y += kmap_types.h | 16 | generic-y += kmap_types.h |
| 17 | generic-y += kprobes.h | 17 | generic-y += kprobes.h |
| 18 | generic-y += linkage.h | ||
| 19 | generic-y += local.h | 18 | generic-y += local.h |
| 20 | generic-y += local64.h | 19 | generic-y += local64.h |
| 21 | generic-y += mcs_spinlock.h | 20 | generic-y += mcs_spinlock.h |
diff --git a/arch/xtensa/include/uapi/asm/Kbuild b/arch/xtensa/include/uapi/asm/Kbuild index 6b43e5049ff7..960bf1e4be53 100644 --- a/arch/xtensa/include/uapi/asm/Kbuild +++ b/arch/xtensa/include/uapi/asm/Kbuild | |||
| @@ -2,4 +2,3 @@ include include/uapi/asm-generic/Kbuild.asm | |||
| 2 | 2 | ||
| 3 | generated-y += unistd_32.h | 3 | generated-y += unistd_32.h |
| 4 | generic-y += kvm_para.h | 4 | generic-y += kvm_para.h |
| 5 | generic-y += socket.h | ||
diff --git a/scripts/Makefile.asm-generic b/scripts/Makefile.asm-generic index a62d2823f6cf..c7d2b7acad26 100644 --- a/scripts/Makefile.asm-generic +++ b/scripts/Makefile.asm-generic | |||
| @@ -14,6 +14,12 @@ src := $(subst /generated,,$(obj)) | |||
| 14 | 14 | ||
| 15 | include scripts/Kbuild.include | 15 | include scripts/Kbuild.include |
| 16 | 16 | ||
| 17 | redundant := $(filter $(mandatory-y) $(generated-y), $(generic-y)) | ||
| 18 | redundant += $(foreach f, $(generic-y), $(if $(wildcard $(srctree)/$(src)/$(f)),$(f))) | ||
| 19 | redundant := $(sort $(redundant)) | ||
| 20 | $(if $(redundant),\ | ||
| 21 | $(warning redundant generic-y found in $(src)/Kbuild: $(redundant))) | ||
| 22 | |||
| 17 | # If arch does not implement mandatory headers, fallback to asm-generic ones. | 23 | # If arch does not implement mandatory headers, fallback to asm-generic ones. |
| 18 | mandatory-y := $(filter-out $(generated-y), $(mandatory-y)) | 24 | mandatory-y := $(filter-out $(generated-y), $(mandatory-y)) |
| 19 | generic-y += $(foreach f, $(mandatory-y), $(if $(wildcard $(srctree)/$(src)/$(f)),,$(f))) | 25 | generic-y += $(foreach f, $(mandatory-y), $(if $(wildcard $(srctree)/$(src)/$(f)),,$(f))) |
