aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-04-12 06:24:49 -0400
committerJens Axboe <axboe@fb.com>2017-04-20 14:09:55 -0400
commit7c4cc30024946dae9530cd6dc0d8d4eb40fca173 (patch)
treeb50f82b17ac02ce2b082a26c4ec7a73dd720db0e
parent2e82b84c01d9438d86079980e22e036eee71e754 (diff)
bdi: Drop 'parent' argument from bdi_register[_va]()
Drop 'parent' argument of bdi_register() and bdi_register_va(). It is always NULL. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--drivers/mtd/mtdcore.c2
-rw-r--r--fs/super.c2
-rw-r--r--include/linux/backing-dev.h9
-rw-r--r--mm/backing-dev.c13
4 files changed, 11 insertions, 15 deletions
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 23e2e56ca54e..1517da3ddd7d 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -1782,7 +1782,7 @@ static struct backing_dev_info * __init mtd_bdi_init(char *name)
1782 * We put '-0' suffix to the name to get the same name format as we 1782 * We put '-0' suffix to the name to get the same name format as we
1783 * used to get. Since this is called only once, we get a unique name. 1783 * used to get. Since this is called only once, we get a unique name.
1784 */ 1784 */
1785 ret = bdi_register(bdi, NULL, "%.28s-0", name); 1785 ret = bdi_register(bdi, "%.28s-0", name);
1786 if (ret) 1786 if (ret)
1787 bdi_put(bdi); 1787 bdi_put(bdi);
1788 1788
diff --git a/fs/super.c b/fs/super.c
index 8444d26926ef..adb0c0de428c 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1272,7 +1272,7 @@ int super_setup_bdi_name(struct super_block *sb, char *fmt, ...)
1272 bdi->name = sb->s_type->name; 1272 bdi->name = sb->s_type->name;
1273 1273
1274 va_start(args, fmt); 1274 va_start(args, fmt);
1275 err = bdi_register_va(bdi, NULL, fmt, args); 1275 err = bdi_register_va(bdi, fmt, args);
1276 va_end(args); 1276 va_end(args);
1277 if (err) { 1277 if (err) {
1278 bdi_put(bdi); 1278 bdi_put(bdi);
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index aaeb2ec5d33c..557d84063934 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -25,11 +25,10 @@ static inline struct backing_dev_info *bdi_get(struct backing_dev_info *bdi)
25 25
26void bdi_put(struct backing_dev_info *bdi); 26void bdi_put(struct backing_dev_info *bdi);
27 27
28__printf(3, 4) 28__printf(2, 3)
29int bdi_register(struct backing_dev_info *bdi, struct device *parent, 29int bdi_register(struct backing_dev_info *bdi, const char *fmt, ...);
30 const char *fmt, ...); 30int bdi_register_va(struct backing_dev_info *bdi, const char *fmt,
31int bdi_register_va(struct backing_dev_info *bdi, struct device *parent, 31 va_list args);
32 const char *fmt, va_list args);
33int bdi_register_owner(struct backing_dev_info *bdi, struct device *owner); 32int bdi_register_owner(struct backing_dev_info *bdi, struct device *owner);
34void bdi_unregister(struct backing_dev_info *bdi); 33void bdi_unregister(struct backing_dev_info *bdi);
35 34
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 4dcd56947f2a..f028a9a472fd 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -856,15 +856,14 @@ struct backing_dev_info *bdi_alloc_node(gfp_t gfp_mask, int node_id)
856} 856}
857EXPORT_SYMBOL(bdi_alloc_node); 857EXPORT_SYMBOL(bdi_alloc_node);
858 858
859int bdi_register_va(struct backing_dev_info *bdi, struct device *parent, 859int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
860 const char *fmt, va_list args)
861{ 860{
862 struct device *dev; 861 struct device *dev;
863 862
864 if (bdi->dev) /* The driver needs to use separate queues per device */ 863 if (bdi->dev) /* The driver needs to use separate queues per device */
865 return 0; 864 return 0;
866 865
867 dev = device_create_vargs(bdi_class, parent, MKDEV(0, 0), bdi, fmt, args); 866 dev = device_create_vargs(bdi_class, NULL, MKDEV(0, 0), bdi, fmt, args);
868 if (IS_ERR(dev)) 867 if (IS_ERR(dev))
869 return PTR_ERR(dev); 868 return PTR_ERR(dev);
870 869
@@ -883,14 +882,13 @@ int bdi_register_va(struct backing_dev_info *bdi, struct device *parent,
883} 882}
884EXPORT_SYMBOL(bdi_register_va); 883EXPORT_SYMBOL(bdi_register_va);
885 884
886int bdi_register(struct backing_dev_info *bdi, struct device *parent, 885int bdi_register(struct backing_dev_info *bdi, const char *fmt, ...)
887 const char *fmt, ...)
888{ 886{
889 va_list args; 887 va_list args;
890 int ret; 888 int ret;
891 889
892 va_start(args, fmt); 890 va_start(args, fmt);
893 ret = bdi_register_va(bdi, parent, fmt, args); 891 ret = bdi_register_va(bdi, fmt, args);
894 va_end(args); 892 va_end(args);
895 return ret; 893 return ret;
896} 894}
@@ -900,8 +898,7 @@ int bdi_register_owner(struct backing_dev_info *bdi, struct device *owner)
900{ 898{
901 int rc; 899 int rc;
902 900
903 rc = bdi_register(bdi, NULL, "%u:%u", MAJOR(owner->devt), 901 rc = bdi_register(bdi, "%u:%u", MAJOR(owner->devt), MINOR(owner->devt));
904 MINOR(owner->devt));
905 if (rc) 902 if (rc)
906 return rc; 903 return rc;
907 /* Leaking owner reference... */ 904 /* Leaking owner reference... */