diff options
author | Shaohua Li <shli@fb.com> | 2016-11-03 17:09:05 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2016-11-07 06:20:52 -0500 |
commit | 7bff0af51012500718971f9cc3485f67252353eb (patch) | |
tree | 944fd07056318af6949167e2d9deca6117231bc4 | |
parent | 8ff42c02193150720815608ed03de8d45aeaf8a8 (diff) |
x86/intel_rdt: Propagate error in rdt_mount() properly
gcc complains:
"warning: ‘dentry’ may be used uninitialized in this function"
The error exit path in rdt_mount(), which deals with a failure in
rdtgroup_create_info_dir(), does not set the error code in dentry and
returns the uninitialized dentry value.
Add the missing error propagation.
[tglx: Massaged changelog ]
Fixes: 4e978d06dedb ("x86/intel_rdt: Add "info" files to resctrl file system")
Signed-off-by: Shaohua Li <shli@fb.com>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Link: http://lkml.kernel.org/r/a56a556f6768dc12cadbf97f49e000189056f90e.1478207143.git.shli@fb.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c index a90ad22b9823..e66c7a58505e 100644 --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | |||
@@ -691,8 +691,10 @@ static struct dentry *rdt_mount(struct file_system_type *fs_type, | |||
691 | closid_init(); | 691 | closid_init(); |
692 | 692 | ||
693 | ret = rdtgroup_create_info_dir(rdtgroup_default.kn); | 693 | ret = rdtgroup_create_info_dir(rdtgroup_default.kn); |
694 | if (ret) | 694 | if (ret) { |
695 | dentry = ERR_PTR(ret); | ||
695 | goto out_cdp; | 696 | goto out_cdp; |
697 | } | ||
696 | 698 | ||
697 | dentry = kernfs_mount(fs_type, flags, rdt_root, | 699 | dentry = kernfs_mount(fs_type, flags, rdt_root, |
698 | RDTGROUP_SUPER_MAGIC, NULL); | 700 | RDTGROUP_SUPER_MAGIC, NULL); |