diff options
author | Dave Hansen <dave.hansen@linux.intel.com> | 2017-11-10 19:12:32 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-11-21 03:34:52 -0500 |
commit | 7b659ee3e1fe0e8eb39730afb903c64e25490ec4 (patch) | |
tree | 9649c9e18c9ac1726b29f2ae4f9c0f4b9446763c | |
parent | 91c49c2deb96ffc3c461eaae70219d89224076b7 (diff) |
x86/pkeys/selftests: Fix protection keys write() warning
write() is marked as having a must-check return value. Check it and
abort if we fail to write an error message from a signal handler.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20171111001232.94813E58@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | tools/testing/selftests/x86/pkey-helpers.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/testing/selftests/x86/pkey-helpers.h b/tools/testing/selftests/x86/pkey-helpers.h index 3818f25391c2..b3cb7670e026 100644 --- a/tools/testing/selftests/x86/pkey-helpers.h +++ b/tools/testing/selftests/x86/pkey-helpers.h | |||
@@ -30,6 +30,7 @@ static inline void sigsafe_printf(const char *format, ...) | |||
30 | if (!dprint_in_signal) { | 30 | if (!dprint_in_signal) { |
31 | vprintf(format, ap); | 31 | vprintf(format, ap); |
32 | } else { | 32 | } else { |
33 | int ret; | ||
33 | int len = vsnprintf(dprint_in_signal_buffer, | 34 | int len = vsnprintf(dprint_in_signal_buffer, |
34 | DPRINT_IN_SIGNAL_BUF_SIZE, | 35 | DPRINT_IN_SIGNAL_BUF_SIZE, |
35 | format, ap); | 36 | format, ap); |
@@ -39,7 +40,9 @@ static inline void sigsafe_printf(const char *format, ...) | |||
39 | */ | 40 | */ |
40 | if (len > DPRINT_IN_SIGNAL_BUF_SIZE) | 41 | if (len > DPRINT_IN_SIGNAL_BUF_SIZE) |
41 | len = DPRINT_IN_SIGNAL_BUF_SIZE; | 42 | len = DPRINT_IN_SIGNAL_BUF_SIZE; |
42 | write(1, dprint_in_signal_buffer, len); | 43 | ret = write(1, dprint_in_signal_buffer, len); |
44 | if (ret < 0) | ||
45 | abort(); | ||
43 | } | 46 | } |
44 | va_end(ap); | 47 | va_end(ap); |
45 | } | 48 | } |