aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 09:40:02 -0500
committerRalf Baechle <ralf@linux-mips.org>2016-01-23 20:20:45 -0500
commit7b42c00a95c02d962b18f8ed8bf59b65ae58d3ee (patch)
tree463994d70c1d1672b349812484a172248a646099
parent6d7b14151d7510ed434f2e587cdae9eca82fc123 (diff)
MIPS: Alchemy: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Cc: linux-mips@linux-mips.org Cc: linux-gpio@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/11921/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r--arch/mips/alchemy/common/gpiolib.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
index f9bc4f520440..84548f704035 100644
--- a/arch/mips/alchemy/common/gpiolib.c
+++ b/arch/mips/alchemy/common/gpiolib.c
@@ -40,7 +40,7 @@
40 40
41static int gpio2_get(struct gpio_chip *chip, unsigned offset) 41static int gpio2_get(struct gpio_chip *chip, unsigned offset)
42{ 42{
43 return alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE); 43 return !!alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE);
44} 44}
45 45
46static void gpio2_set(struct gpio_chip *chip, unsigned offset, int value) 46static void gpio2_set(struct gpio_chip *chip, unsigned offset, int value)
@@ -68,7 +68,7 @@ static int gpio2_to_irq(struct gpio_chip *chip, unsigned offset)
68 68
69static int gpio1_get(struct gpio_chip *chip, unsigned offset) 69static int gpio1_get(struct gpio_chip *chip, unsigned offset)
70{ 70{
71 return alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE); 71 return !!alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE);
72} 72}
73 73
74static void gpio1_set(struct gpio_chip *chip, 74static void gpio1_set(struct gpio_chip *chip,
@@ -119,7 +119,7 @@ struct gpio_chip alchemy_gpio_chip[] = {
119 119
120static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off) 120static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off)
121{ 121{
122 return au1300_gpio_get_value(off + AU1300_GPIO_BASE); 122 return !!au1300_gpio_get_value(off + AU1300_GPIO_BASE);
123} 123}
124 124
125static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v) 125static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)