diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2016-08-01 07:32:32 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-08-01 07:32:32 -0400 |
commit | 7a66ecfd319af8fe4f4c3eadf019b998c93d6687 (patch) | |
tree | 8348e0748e0f7e8c4cf16dd0d39f16fa617542cf | |
parent | 06e23d51151fd06c225c80ace26675532bdf406d (diff) | |
parent | 602553073892c18f723f8aa090153a23b1312a16 (diff) |
Merge tag 'backlight-for-linus-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight
Pull backlight updates from Lee Jones:
"Add support for an enable regulator to lp855x_bl"
* tag 'backlight-for-linus-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight:
backlight: lp855x: Add enable regulator
-rw-r--r-- | Documentation/devicetree/bindings/leds/backlight/lp855x.txt | 2 | ||||
-rw-r--r-- | drivers/video/backlight/lp855x_bl.c | 29 |
2 files changed, 31 insertions, 0 deletions
diff --git a/Documentation/devicetree/bindings/leds/backlight/lp855x.txt b/Documentation/devicetree/bindings/leds/backlight/lp855x.txt index 0a3ecbc3a1b9..88f56641fc28 100644 --- a/Documentation/devicetree/bindings/leds/backlight/lp855x.txt +++ b/Documentation/devicetree/bindings/leds/backlight/lp855x.txt | |||
@@ -13,6 +13,7 @@ Optional properties: | |||
13 | - rom-addr: Register address of ROM area to be updated (u8) | 13 | - rom-addr: Register address of ROM area to be updated (u8) |
14 | - rom-val: Register value to be updated (u8) | 14 | - rom-val: Register value to be updated (u8) |
15 | - power-supply: Regulator which controls the 3V rail | 15 | - power-supply: Regulator which controls the 3V rail |
16 | - enable-supply: Regulator which controls the EN/VDDIO input | ||
16 | 17 | ||
17 | Example: | 18 | Example: |
18 | 19 | ||
@@ -57,6 +58,7 @@ Example: | |||
57 | backlight@2c { | 58 | backlight@2c { |
58 | compatible = "ti,lp8557"; | 59 | compatible = "ti,lp8557"; |
59 | reg = <0x2c>; | 60 | reg = <0x2c>; |
61 | enable-supply = <&backlight_vddio>; | ||
60 | power-supply = <&backlight_vdd>; | 62 | power-supply = <&backlight_vdd>; |
61 | 63 | ||
62 | dev-ctrl = /bits/ 8 <0x41>; | 64 | dev-ctrl = /bits/ 8 <0x41>; |
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index e5b14f52628f..939f057836e1 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c | |||
@@ -13,6 +13,7 @@ | |||
13 | #include <linux/slab.h> | 13 | #include <linux/slab.h> |
14 | #include <linux/i2c.h> | 14 | #include <linux/i2c.h> |
15 | #include <linux/backlight.h> | 15 | #include <linux/backlight.h> |
16 | #include <linux/delay.h> | ||
16 | #include <linux/err.h> | 17 | #include <linux/err.h> |
17 | #include <linux/of.h> | 18 | #include <linux/of.h> |
18 | #include <linux/platform_data/lp855x.h> | 19 | #include <linux/platform_data/lp855x.h> |
@@ -74,6 +75,7 @@ struct lp855x { | |||
74 | struct lp855x_platform_data *pdata; | 75 | struct lp855x_platform_data *pdata; |
75 | struct pwm_device *pwm; | 76 | struct pwm_device *pwm; |
76 | struct regulator *supply; /* regulator for VDD input */ | 77 | struct regulator *supply; /* regulator for VDD input */ |
78 | struct regulator *enable; /* regulator for EN/VDDIO input */ | ||
77 | }; | 79 | }; |
78 | 80 | ||
79 | static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data) | 81 | static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data) |
@@ -433,6 +435,19 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) | |||
433 | lp->supply = NULL; | 435 | lp->supply = NULL; |
434 | } | 436 | } |
435 | 437 | ||
438 | lp->enable = devm_regulator_get_optional(lp->dev, "enable"); | ||
439 | if (IS_ERR(lp->enable)) { | ||
440 | ret = PTR_ERR(lp->enable); | ||
441 | if (ret == -ENODEV) { | ||
442 | lp->enable = NULL; | ||
443 | } else { | ||
444 | if (ret != -EPROBE_DEFER) | ||
445 | dev_err(lp->dev, "error getting enable regulator: %d\n", | ||
446 | ret); | ||
447 | return ret; | ||
448 | } | ||
449 | } | ||
450 | |||
436 | if (lp->supply) { | 451 | if (lp->supply) { |
437 | ret = regulator_enable(lp->supply); | 452 | ret = regulator_enable(lp->supply); |
438 | if (ret < 0) { | 453 | if (ret < 0) { |
@@ -441,6 +456,20 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) | |||
441 | } | 456 | } |
442 | } | 457 | } |
443 | 458 | ||
459 | if (lp->enable) { | ||
460 | ret = regulator_enable(lp->enable); | ||
461 | if (ret < 0) { | ||
462 | dev_err(lp->dev, "failed to enable vddio: %d\n", ret); | ||
463 | return ret; | ||
464 | } | ||
465 | |||
466 | /* | ||
467 | * LP8555 datasheet says t_RESPONSE (time between VDDIO and | ||
468 | * I2C) is 1ms. | ||
469 | */ | ||
470 | usleep_range(1000, 2000); | ||
471 | } | ||
472 | |||
444 | i2c_set_clientdata(cl, lp); | 473 | i2c_set_clientdata(cl, lp); |
445 | 474 | ||
446 | ret = lp855x_configure(lp); | 475 | ret = lp855x_configure(lp); |