diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-21 16:41:38 -0400 |
---|---|---|
committer | Stephen Boyd <sboyd@codeaurora.org> | 2015-10-21 19:16:34 -0400 |
commit | 77cb8ee67582ad815310c4544c7c408056fe59bf (patch) | |
tree | 5cb89485750009fa817e8a68e53bd5dc4eb3fb7b | |
parent | a1bdfbaf9900a7bafebdba796b034371ee1c3f5e (diff) |
clk: imx27: add missing of_node_put
for_each_compatible_node performs an of_node_get on each iteration, so a
break out of the loop requires an of_node_put.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
local idexpression n;
expression e;
@@
for_each_compatible_node(n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
-rw-r--r-- | drivers/clk/imx/clk-imx27.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/imx/clk-imx27.c b/drivers/clk/imx/clk-imx27.c index 0d7b8df04dfa..cf5cf75a4848 100644 --- a/drivers/clk/imx/clk-imx27.c +++ b/drivers/clk/imx/clk-imx27.c | |||
@@ -261,8 +261,10 @@ static void __init mx27_clocks_init_dt(struct device_node *np) | |||
261 | if (!of_device_is_compatible(refnp, "fsl,imx-osc26m")) | 261 | if (!of_device_is_compatible(refnp, "fsl,imx-osc26m")) |
262 | continue; | 262 | continue; |
263 | 263 | ||
264 | if (!of_property_read_u32(refnp, "clock-frequency", &fref)) | 264 | if (!of_property_read_u32(refnp, "clock-frequency", &fref)) { |
265 | of_node_put(refnp); | ||
265 | break; | 266 | break; |
267 | } | ||
266 | } | 268 | } |
267 | 269 | ||
268 | ccm = of_iomap(np, 0); | 270 | ccm = of_iomap(np, 0); |