diff options
author | Jiri Slaby <jslaby@suse.cz> | 2015-10-11 09:22:44 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-10-18 00:14:06 -0400 |
commit | 77bdec6f0face395ceb303ee7f2525b9dbbeb036 (patch) | |
tree | 5eb11fddaf6703eb73c93a565735068293230b88 | |
parent | f148d6d7b79adb42a8e7fa95bf6be5b607015f26 (diff) |
serial: at91, fix rs485 properties
There is a misplaced bracket in atmel_init_rs485 which sets
rs485-rx-during-tx and rs485-enabled-at-boot-time only if
rs485-rts-delay is set in of.
This is clearly a bug, so fix it by moving the bracket to the proper
place.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Elen Song <elen.song@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/tty/serial/atmel_serial.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 3a218482a471..94294558943c 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c | |||
@@ -1682,15 +1682,15 @@ static void atmel_init_rs485(struct uart_port *port, | |||
1682 | struct atmel_uart_data *pdata = dev_get_platdata(&pdev->dev); | 1682 | struct atmel_uart_data *pdata = dev_get_platdata(&pdev->dev); |
1683 | 1683 | ||
1684 | if (np) { | 1684 | if (np) { |
1685 | struct serial_rs485 *rs485conf = &port->rs485; | ||
1685 | u32 rs485_delay[2]; | 1686 | u32 rs485_delay[2]; |
1686 | /* rs485 properties */ | 1687 | /* rs485 properties */ |
1687 | if (of_property_read_u32_array(np, "rs485-rts-delay", | 1688 | if (of_property_read_u32_array(np, "rs485-rts-delay", |
1688 | rs485_delay, 2) == 0) { | 1689 | rs485_delay, 2) == 0) { |
1689 | struct serial_rs485 *rs485conf = &port->rs485; | ||
1690 | |||
1691 | rs485conf->delay_rts_before_send = rs485_delay[0]; | 1690 | rs485conf->delay_rts_before_send = rs485_delay[0]; |
1692 | rs485conf->delay_rts_after_send = rs485_delay[1]; | 1691 | rs485conf->delay_rts_after_send = rs485_delay[1]; |
1693 | rs485conf->flags = 0; | 1692 | rs485conf->flags = 0; |
1693 | } | ||
1694 | 1694 | ||
1695 | if (of_get_property(np, "rs485-rx-during-tx", NULL)) | 1695 | if (of_get_property(np, "rs485-rx-during-tx", NULL)) |
1696 | rs485conf->flags |= SER_RS485_RX_DURING_TX; | 1696 | rs485conf->flags |= SER_RS485_RX_DURING_TX; |
@@ -1698,7 +1698,6 @@ static void atmel_init_rs485(struct uart_port *port, | |||
1698 | if (of_get_property(np, "linux,rs485-enabled-at-boot-time", | 1698 | if (of_get_property(np, "linux,rs485-enabled-at-boot-time", |
1699 | NULL)) | 1699 | NULL)) |
1700 | rs485conf->flags |= SER_RS485_ENABLED; | 1700 | rs485conf->flags |= SER_RS485_ENABLED; |
1701 | } | ||
1702 | } else { | 1701 | } else { |
1703 | port->rs485 = pdata->rs485; | 1702 | port->rs485 = pdata->rs485; |
1704 | } | 1703 | } |