aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2018-01-10 09:37:13 -0500
committerLinus Walleij <linus.walleij@linaro.org>2018-01-11 04:49:32 -0500
commit76e28f5ffed82b1e81a86c4eb8d0420515765620 (patch)
tree898e2d5adcf2f6ce1e7f76fe9a126b9598cf781d
parent92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72 (diff)
gpio: thunderx: fix error return code in thunderx_gpio_probe()
Fix to return error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: 5a2a30024d8c ("gpio: Add gpio driver support for ThunderX and OCTEON-TX") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: David Daney <david.daney@cavium.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpio-thunderx.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
index b5adb79a631a..d16e9d4a129b 100644
--- a/drivers/gpio/gpio-thunderx.c
+++ b/drivers/gpio/gpio-thunderx.c
@@ -553,8 +553,10 @@ static int thunderx_gpio_probe(struct pci_dev *pdev,
553 txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain, 553 txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
554 0, 0, of_node_to_fwnode(dev->of_node), 554 0, 0, of_node_to_fwnode(dev->of_node),
555 &thunderx_gpio_irqd_ops, txgpio); 555 &thunderx_gpio_irqd_ops, txgpio);
556 if (!txgpio->irqd) 556 if (!txgpio->irqd) {
557 err = -ENOMEM;
557 goto out; 558 goto out;
559 }
558 560
559 /* Push on irq_data and the domain for each line. */ 561 /* Push on irq_data and the domain for each line. */
560 for (i = 0; i < ngpio; i++) { 562 for (i = 0; i < ngpio; i++) {