aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYurii Pavlenko <pyldev@gmail.com>2017-09-23 16:13:37 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-10-04 04:54:43 -0400
commit750b1a6894ecc9b178c6e3d0a1170122971b2036 (patch)
tree8cac0608fa1abce3d382757ed5fbd47ab5332e3b
parent006e202fe6f91c9dd26f754ff0c7f38f2363aaf8 (diff)
staging: irda: au1k_ir.c fix warning: Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Yurii Pavlenko <pyldev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/irda/drivers/au1k_ir.c40
1 files changed, 18 insertions, 22 deletions
diff --git a/drivers/staging/irda/drivers/au1k_ir.c b/drivers/staging/irda/drivers/au1k_ir.c
index be4ea6aa57a9..73e3e4b041bf 100644
--- a/drivers/staging/irda/drivers/au1k_ir.c
+++ b/drivers/staging/irda/drivers/au1k_ir.c
@@ -290,8 +290,7 @@ static int au1k_irda_set_speed(struct net_device *dev, int speed)
290 while (irda_read(aup, IR_STATUS) & (IR_RX_STATUS | IR_TX_STATUS)) { 290 while (irda_read(aup, IR_STATUS) & (IR_RX_STATUS | IR_TX_STATUS)) {
291 msleep(20); 291 msleep(20);
292 if (!timeout--) { 292 if (!timeout--) {
293 printk(KERN_ERR "%s: rx/tx disable timeout\n", 293 netdev_err(dev, "rx/tx disable timeout\n");
294 dev->name);
295 break; 294 break;
296 } 295 }
297 } 296 }
@@ -349,7 +348,7 @@ static int au1k_irda_set_speed(struct net_device *dev, int speed)
349 IR_RX_ENABLE); 348 IR_RX_ENABLE);
350 break; 349 break;
351 default: 350 default:
352 printk(KERN_ERR "%s unsupported speed %x\n", dev->name, speed); 351 netdev_err(dev, "unsupported speed %x\n", speed);
353 ret = -EINVAL; 352 ret = -EINVAL;
354 break; 353 break;
355 } 354 }
@@ -361,18 +360,18 @@ static int au1k_irda_set_speed(struct net_device *dev, int speed)
361 irda_write(aup, IR_RING_PROMPT, 0); 360 irda_write(aup, IR_RING_PROMPT, 0);
362 361
363 if (control & (1 << 14)) { 362 if (control & (1 << 14)) {
364 printk(KERN_ERR "%s: configuration error\n", dev->name); 363 netdev_err(dev, "configuration error\n");
365 } else { 364 } else {
366 if (control & (1 << 11)) 365 if (control & (1 << 11))
367 printk(KERN_DEBUG "%s Valid SIR config\n", dev->name); 366 netdev_debug(dev, "Valid SIR config\n");
368 if (control & (1 << 12)) 367 if (control & (1 << 12))
369 printk(KERN_DEBUG "%s Valid MIR config\n", dev->name); 368 netdev_debug(dev, "Valid MIR config\n");
370 if (control & (1 << 13)) 369 if (control & (1 << 13))
371 printk(KERN_DEBUG "%s Valid FIR config\n", dev->name); 370 netdev_debug(dev, "Valid FIR config\n");
372 if (control & (1 << 10)) 371 if (control & (1 << 10))
373 printk(KERN_DEBUG "%s TX enabled\n", dev->name); 372 netdev_debug(dev, "TX enabled\n");
374 if (control & (1 << 9)) 373 if (control & (1 << 9))
375 printk(KERN_DEBUG "%s RX enabled\n", dev->name); 374 netdev_debug(dev, "RX enabled\n");
376 } 375 }
377 376
378 return ret; 377 return ret;
@@ -584,23 +583,21 @@ static int au1k_irda_start(struct net_device *dev)
584 583
585 retval = au1k_init(dev); 584 retval = au1k_init(dev);
586 if (retval) { 585 if (retval) {
587 printk(KERN_ERR "%s: error in au1k_init\n", dev->name); 586 netdev_err(dev, "error in au1k_init\n");
588 return retval; 587 return retval;
589 } 588 }
590 589
591 retval = request_irq(aup->irq_tx, &au1k_irda_interrupt, 0, 590 retval = request_irq(aup->irq_tx, &au1k_irda_interrupt, 0,
592 dev->name, dev); 591 dev->name, dev);
593 if (retval) { 592 if (retval) {
594 printk(KERN_ERR "%s: unable to get IRQ %d\n", 593 netdev_err(dev, "unable to get IRQ %d\n", dev->irq);
595 dev->name, dev->irq);
596 return retval; 594 return retval;
597 } 595 }
598 retval = request_irq(aup->irq_rx, &au1k_irda_interrupt, 0, 596 retval = request_irq(aup->irq_rx, &au1k_irda_interrupt, 0,
599 dev->name, dev); 597 dev->name, dev);
600 if (retval) { 598 if (retval) {
601 free_irq(aup->irq_tx, dev); 599 free_irq(aup->irq_tx, dev);
602 printk(KERN_ERR "%s: unable to get IRQ %d\n", 600 netdev_err(dev, "unable to get IRQ %d\n", dev->irq);
603 dev->name, dev->irq);
604 return retval; 601 return retval;
605 } 602 }
606 603
@@ -673,12 +670,12 @@ static int au1k_irda_hard_xmit(struct sk_buff *skb, struct net_device *dev)
673 flags = ptxd->flags; 670 flags = ptxd->flags;
674 671
675 if (flags & AU_OWN) { 672 if (flags & AU_OWN) {
676 printk(KERN_DEBUG "%s: tx_full\n", dev->name); 673 netdev_debug(dev, "tx_full\n");
677 netif_stop_queue(dev); 674 netif_stop_queue(dev);
678 aup->tx_full = 1; 675 aup->tx_full = 1;
679 return 1; 676 return 1;
680 } else if (((aup->tx_head + 1) & (NUM_IR_DESC - 1)) == aup->tx_tail) { 677 } else if (((aup->tx_head + 1) & (NUM_IR_DESC - 1)) == aup->tx_tail) {
681 printk(KERN_DEBUG "%s: tx_full\n", dev->name); 678 netdev_debug(dev, "tx_full\n");
682 netif_stop_queue(dev); 679 netif_stop_queue(dev);
683 aup->tx_full = 1; 680 aup->tx_full = 1;
684 return 1; 681 return 1;
@@ -688,7 +685,7 @@ static int au1k_irda_hard_xmit(struct sk_buff *skb, struct net_device *dev)
688 685
689#if 0 686#if 0
690 if (irda_read(aup, IR_RX_BYTE_CNT) != 0) { 687 if (irda_read(aup, IR_RX_BYTE_CNT) != 0) {
691 printk(KERN_DEBUG "tx warning: rx byte cnt %x\n", 688 netdev_debug(dev, "tx warning: rx byte cnt %x\n",
692 irda_read(aup, IR_RX_BYTE_CNT)); 689 irda_read(aup, IR_RX_BYTE_CNT));
693 } 690 }
694#endif 691#endif
@@ -726,7 +723,7 @@ static void au1k_tx_timeout(struct net_device *dev)
726 u32 speed; 723 u32 speed;
727 struct au1k_private *aup = netdev_priv(dev); 724 struct au1k_private *aup = netdev_priv(dev);
728 725
729 printk(KERN_ERR "%s: tx timeout\n", dev->name); 726 netdev_err(dev, "tx timeout\n");
730 speed = aup->speed; 727 speed = aup->speed;
731 aup->speed = 0; 728 aup->speed = 0;
732 au1k_irda_set_speed(dev, speed); 729 au1k_irda_set_speed(dev, speed);
@@ -751,8 +748,7 @@ static int au1k_irda_ioctl(struct net_device *dev, struct ifreq *ifreq, int cmd)
751 ret = au1k_irda_set_speed(dev, 748 ret = au1k_irda_set_speed(dev,
752 rq->ifr_baudrate); 749 rq->ifr_baudrate);
753 else { 750 else {
754 printk(KERN_ERR "%s ioctl: !netif_running\n", 751 netdev_err(dev, "ioctl: !netif_running\n");
755 dev->name);
756 ret = 0; 752 ret = 0;
757 } 753 }
758 } 754 }
@@ -868,7 +864,7 @@ out3:
868out2: 864out2:
869 kfree(aup->rx_buff.head); 865 kfree(aup->rx_buff.head);
870out1: 866out1:
871 printk(KERN_ERR "au1k_irda_net_init() failed. Returns %d\n", retval); 867 netdev_err(dev, "au1k_irda_net_init() failed. Returns %d\n");
872 return retval; 868 return retval;
873} 869}
874 870
@@ -934,7 +930,7 @@ static int au1k_irda_probe(struct platform_device *pdev)
934 930
935 platform_set_drvdata(pdev, dev); 931 platform_set_drvdata(pdev, dev);
936 932
937 printk(KERN_INFO "IrDA: Registered device %s\n", dev->name); 933 netdev_info(dev, "IrDA: Registered device\n");
938 return 0; 934 return 0;
939 935
940out4: 936out4: