aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-05-29 11:31:06 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-05-31 06:54:22 -0400
commit743d1effe6c1c6b2b42e9e4ca958a4403373702d (patch)
tree9ed265bfcc56860dad971464f1b91c6f4cde27e9
parentedbeb6bc696ec727815bc6b17f7c29f4102d94b6 (diff)
USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi <balbi@kernel.org> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/gadget/udc/renesas_usb3.c18
1 files changed, 3 insertions, 15 deletions
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index 5caf78bbbf7c..977ea1a02cf9 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2391,22 +2391,10 @@ static const struct file_operations renesas_usb3_b_device_fops = {
2391static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3, 2391static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
2392 struct device *dev) 2392 struct device *dev)
2393{ 2393{
2394 struct dentry *root, *file; 2394 usb3->dentry = debugfs_create_dir(dev_name(dev), NULL);
2395 2395
2396 root = debugfs_create_dir(dev_name(dev), NULL); 2396 debugfs_create_file("b_device", 0644, usb3->dentry, usb3,
2397 if (IS_ERR_OR_NULL(root)) { 2397 &renesas_usb3_b_device_fops);
2398 dev_info(dev, "%s: Can't create the root\n", __func__);
2399 return;
2400 }
2401
2402 file = debugfs_create_file("b_device", 0644, root, usb3,
2403 &renesas_usb3_b_device_fops);
2404 if (!file) {
2405 dev_info(dev, "%s: Can't create debugfs mode\n", __func__);
2406 debugfs_remove_recursive(root);
2407 } else {
2408 usb3->dentry = root;
2409 }
2410} 2398}
2411 2399
2412/*------- platform_driver ------------------------------------------------*/ 2400/*------- platform_driver ------------------------------------------------*/