diff options
author | Kefeng Wang <wangkefeng.wang@huawei.com> | 2017-01-24 07:08:29 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2017-01-24 11:15:01 -0500 |
commit | 73b2951414f661e22dc4b88e4e6590c9406cf822 (patch) | |
tree | 1b9044182dd846786b41b2ec5647aac89ed5a844 | |
parent | 5946fdaee4ba449e8fbb5d403e1ed69437f916e8 (diff) |
ata: pata_of_platform: using of_property_read_u32() helper
Using better of_property_read_u32() than generic of_get_property().
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | drivers/ata/pata_of_platform.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c index b6b7af894d9d..201a32d0627f 100644 --- a/drivers/ata/pata_of_platform.c +++ b/drivers/ata/pata_of_platform.c | |||
@@ -32,7 +32,6 @@ static int pata_of_platform_probe(struct platform_device *ofdev) | |||
32 | unsigned int reg_shift = 0; | 32 | unsigned int reg_shift = 0; |
33 | int pio_mode = 0; | 33 | int pio_mode = 0; |
34 | int pio_mask; | 34 | int pio_mask; |
35 | const u32 *prop; | ||
36 | 35 | ||
37 | ret = of_address_to_resource(dn, 0, &io_res); | 36 | ret = of_address_to_resource(dn, 0, &io_res); |
38 | if (ret) { | 37 | if (ret) { |
@@ -50,13 +49,9 @@ static int pata_of_platform_probe(struct platform_device *ofdev) | |||
50 | 49 | ||
51 | irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0); | 50 | irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0); |
52 | 51 | ||
53 | prop = of_get_property(dn, "reg-shift", NULL); | 52 | of_property_read_u32(dn, "reg-shift", ®_shift); |
54 | if (prop) | ||
55 | reg_shift = be32_to_cpup(prop); | ||
56 | 53 | ||
57 | prop = of_get_property(dn, "pio-mode", NULL); | 54 | if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) { |
58 | if (prop) { | ||
59 | pio_mode = be32_to_cpup(prop); | ||
60 | if (pio_mode > 6) { | 55 | if (pio_mode > 6) { |
61 | dev_err(&ofdev->dev, "invalid pio-mode\n"); | 56 | dev_err(&ofdev->dev, "invalid pio-mode\n"); |
62 | return -EINVAL; | 57 | return -EINVAL; |