aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Neukum <oneukum@suse.com>2016-11-02 09:42:52 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-07 04:15:22 -0500
commit7309aa847ead3fa561663b16779a0dde8c64cc7c (patch)
treebaeaaec22975af8624363b49e9ee4881277313cc
parentc289d0eff3d5a594c577c0dc162412a2cad075a4 (diff)
cdc-acm: fix uninitialized variable
variable struct usb_cdc_parsed_header h may be used uninitialized in acm_probe. In kernel 4.8. /* handle quirks deadly to normal probing*/ if (quirks == NO_UNION_NORMAL) ... goto skip_normal_probe; } we bypass call to cdc_parse_cdc_header(&h, intf, buffer, buflen); but later use h in if (h.usb_cdc_country_functional_desc) { /* export the country data */ Signed-off-by: Oliver Neukum <oneukum@suse.com> CC: stable@vger.kernel.org Reported-by: Victor Sologoubov <victor0@rambler.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/class/cdc-acm.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 78f0f85bebdc..4ad4ca44058b 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1161,6 +1161,8 @@ static int acm_probe(struct usb_interface *intf,
1161 if (quirks == IGNORE_DEVICE) 1161 if (quirks == IGNORE_DEVICE)
1162 return -ENODEV; 1162 return -ENODEV;
1163 1163
1164 memset(&h, 0x00, sizeof(struct usb_cdc_parsed_header));
1165
1164 num_rx_buf = (quirks == SINGLE_RX_URB) ? 1 : ACM_NR; 1166 num_rx_buf = (quirks == SINGLE_RX_URB) ? 1 : ACM_NR;
1165 1167
1166 /* handle quirks deadly to normal probing*/ 1168 /* handle quirks deadly to normal probing*/