diff options
author | Gavin Shan <gwshan@linux.vnet.ibm.com> | 2017-02-07 22:11:03 -0500 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2017-02-17 06:18:21 -0500 |
commit | 727597d12140b342a3deef10348b5edeb076275d (patch) | |
tree | e95727fe4fcb6936002f51b79c75f2cbeb248be7 | |
parent | c618f6b188a9170f67e4abd478d250cc72aed1e1 (diff) |
powerpc/kernel: Remove error message in pcibios_setup_phb_resources()
The CAPI driver creates virtual PHB (vPHB) from the CAPI adapter.
The vPHB's IO and memory windows aren't built from device-tree node
as we do for normal PHBs. A error message is thrown in below path
when trying to probe AFUs contained in the adapter. The error message
is confusing and unnecessary.
cxl_probe()
pci_init_afu()
cxl_pci_vphb_add()
pcibios_scan_phb()
pcibios_setup_phb_resources()
This removes the error message. We might have the case where the
first memory window on real PHB isn't populated properly because
of error in "ranges" property in the device-tree node. We can check
the device-tree instead for that. This also removes one unnecessary
blank line in the function.
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
-rw-r--r-- | arch/powerpc/kernel/pci-common.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index 74bec5498972..05bfdaeaa2f9 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c | |||
@@ -1559,16 +1559,10 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose, | |||
1559 | /* Hookup PHB Memory resources */ | 1559 | /* Hookup PHB Memory resources */ |
1560 | for (i = 0; i < 3; ++i) { | 1560 | for (i = 0; i < 3; ++i) { |
1561 | res = &hose->mem_resources[i]; | 1561 | res = &hose->mem_resources[i]; |
1562 | if (!res->flags) { | 1562 | if (!res->flags) |
1563 | if (i == 0) | ||
1564 | printk(KERN_ERR "PCI: Memory resource 0 not set for " | ||
1565 | "host bridge %s (domain %d)\n", | ||
1566 | hose->dn->full_name, hose->global_number); | ||
1567 | continue; | 1563 | continue; |
1568 | } | ||
1569 | offset = hose->mem_offset[i]; | ||
1570 | |||
1571 | 1564 | ||
1565 | offset = hose->mem_offset[i]; | ||
1572 | pr_debug("PCI: PHB MEM resource %d = %pR off 0x%08llx\n", i, | 1566 | pr_debug("PCI: PHB MEM resource %d = %pR off 0x%08llx\n", i, |
1573 | res, (unsigned long long)offset); | 1567 | res, (unsigned long long)offset); |
1574 | 1568 | ||