diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2016-05-27 13:59:20 -0400 |
---|---|---|
committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2016-05-30 10:01:37 -0400 |
commit | 72660ce0202601c092f83604326aa7cfd25b5a4d (patch) | |
tree | d62dd518d0eddfaa0bf0a23d20524aef0e6c4366 | |
parent | 78108b7c0aeda8a764dc4c3d50e522b6bb7f358b (diff) |
drm/i915: Use plane->name in debug prints
We have plane->name, so let's use that in debug messages instead
of just printing the more or less useless object ID.
v2: slap on a commit message
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1464371966-15190-3-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 38 |
1 files changed, 22 insertions, 16 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index fecabc78297b..f636fd37ef0b 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -4310,9 +4310,9 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state, | |||
4310 | 4310 | ||
4311 | bool force_detach = !fb || !plane_state->visible; | 4311 | bool force_detach = !fb || !plane_state->visible; |
4312 | 4312 | ||
4313 | DRM_DEBUG_KMS("Updating scaler for [PLANE:%d] scaler_user index %u.%u\n", | 4313 | DRM_DEBUG_KMS("Updating scaler for [PLANE:%d:%s] scaler_user index %u.%u\n", |
4314 | intel_plane->base.base.id, intel_crtc->pipe, | 4314 | intel_plane->base.base.id, intel_plane->base.name, |
4315 | drm_plane_index(&intel_plane->base)); | 4315 | intel_crtc->pipe, drm_plane_index(&intel_plane->base)); |
4316 | 4316 | ||
4317 | ret = skl_update_scaler(crtc_state, force_detach, | 4317 | ret = skl_update_scaler(crtc_state, force_detach, |
4318 | drm_plane_index(&intel_plane->base), | 4318 | drm_plane_index(&intel_plane->base), |
@@ -4328,8 +4328,9 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state, | |||
4328 | 4328 | ||
4329 | /* check colorkey */ | 4329 | /* check colorkey */ |
4330 | if (plane_state->ckey.flags != I915_SET_COLORKEY_NONE) { | 4330 | if (plane_state->ckey.flags != I915_SET_COLORKEY_NONE) { |
4331 | DRM_DEBUG_KMS("[PLANE:%d] scaling with color key not allowed", | 4331 | DRM_DEBUG_KMS("[PLANE:%d:%s] scaling with color key not allowed", |
4332 | intel_plane->base.base.id); | 4332 | intel_plane->base.base.id, |
4333 | intel_plane->base.name); | ||
4333 | return -EINVAL; | 4334 | return -EINVAL; |
4334 | } | 4335 | } |
4335 | 4336 | ||
@@ -4348,8 +4349,9 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state, | |||
4348 | case DRM_FORMAT_VYUY: | 4349 | case DRM_FORMAT_VYUY: |
4349 | break; | 4350 | break; |
4350 | default: | 4351 | default: |
4351 | DRM_DEBUG_KMS("[PLANE:%d] FB:%d unsupported scaling format 0x%x\n", | 4352 | DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n", |
4352 | intel_plane->base.base.id, fb->base.id, fb->pixel_format); | 4353 | intel_plane->base.base.id, intel_plane->base.name, |
4354 | fb->base.id, fb->pixel_format); | ||
4353 | return -EINVAL; | 4355 | return -EINVAL; |
4354 | } | 4356 | } |
4355 | 4357 | ||
@@ -11977,13 +11979,15 @@ int intel_plane_atomic_calc_changes(struct drm_crtc_state *crtc_state, | |||
11977 | turn_off = was_visible && (!visible || mode_changed); | 11979 | turn_off = was_visible && (!visible || mode_changed); |
11978 | turn_on = visible && (!was_visible || mode_changed); | 11980 | turn_on = visible && (!was_visible || mode_changed); |
11979 | 11981 | ||
11980 | DRM_DEBUG_ATOMIC("[CRTC:%d:%s] has [PLANE:%i] with fb %i\n", | 11982 | DRM_DEBUG_ATOMIC("[CRTC:%d:%s] has [PLANE:%d:%s] with fb %i\n", |
11981 | intel_crtc->base.base.id, | 11983 | intel_crtc->base.base.id, |
11982 | intel_crtc->base.name, | 11984 | intel_crtc->base.name, |
11983 | plane->base.id, fb ? fb->base.id : -1); | 11985 | plane->base.id, plane->name, |
11986 | fb ? fb->base.id : -1); | ||
11984 | 11987 | ||
11985 | DRM_DEBUG_ATOMIC("[PLANE:%i] visible %i -> %i, off %i, on %i, ms %i\n", | 11988 | DRM_DEBUG_ATOMIC("[PLANE:%d:%s] visible %i -> %i, off %i, on %i, ms %i\n", |
11986 | plane->base.id, was_visible, visible, | 11989 | plane->base.id, plane->name, |
11990 | was_visible, visible, | ||
11987 | turn_off, turn_on, mode_changed); | 11991 | turn_off, turn_on, mode_changed); |
11988 | 11992 | ||
11989 | if (turn_on) { | 11993 | if (turn_on) { |
@@ -12376,18 +12380,20 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, | |||
12376 | state = to_intel_plane_state(plane->state); | 12380 | state = to_intel_plane_state(plane->state); |
12377 | fb = state->base.fb; | 12381 | fb = state->base.fb; |
12378 | if (!fb) { | 12382 | if (!fb) { |
12379 | DRM_DEBUG_KMS("%s PLANE:%d plane: %u.%u idx: %d " | 12383 | DRM_DEBUG_KMS("%s [PLANE:%d:%s] plane: %u.%u idx: %d " |
12380 | "disabled, scaler_id = %d\n", | 12384 | "disabled, scaler_id = %d\n", |
12381 | plane->type == DRM_PLANE_TYPE_CURSOR ? "CURSOR" : "STANDARD", | 12385 | plane->type == DRM_PLANE_TYPE_CURSOR ? "CURSOR" : "STANDARD", |
12382 | plane->base.id, intel_plane->pipe, | 12386 | plane->base.id, plane->name, |
12387 | intel_plane->pipe, | ||
12383 | (crtc->base.primary == plane) ? 0 : intel_plane->plane + 1, | 12388 | (crtc->base.primary == plane) ? 0 : intel_plane->plane + 1, |
12384 | drm_plane_index(plane), state->scaler_id); | 12389 | drm_plane_index(plane), state->scaler_id); |
12385 | continue; | 12390 | continue; |
12386 | } | 12391 | } |
12387 | 12392 | ||
12388 | DRM_DEBUG_KMS("%s PLANE:%d plane: %u.%u idx: %d enabled", | 12393 | DRM_DEBUG_KMS("%s [PLANE:%d:%s] plane: %u.%u idx: %d enabled", |
12389 | plane->type == DRM_PLANE_TYPE_CURSOR ? "CURSOR" : "STANDARD", | 12394 | plane->type == DRM_PLANE_TYPE_CURSOR ? "CURSOR" : "STANDARD", |
12390 | plane->base.id, intel_plane->pipe, | 12395 | plane->base.id, plane->name, |
12396 | intel_plane->pipe, | ||
12391 | crtc->base.primary == plane ? 0 : intel_plane->plane + 1, | 12397 | crtc->base.primary == plane ? 0 : intel_plane->plane + 1, |
12392 | drm_plane_index(plane)); | 12398 | drm_plane_index(plane)); |
12393 | DRM_DEBUG_KMS("\tFB:%d, fb = %ux%u format = 0x%x", | 12399 | DRM_DEBUG_KMS("\tFB:%d, fb = %ux%u format = 0x%x", |