diff options
author | Carlo Caione <carlo@endlessm.com> | 2017-05-30 16:39:46 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2017-06-02 08:13:22 -0400 |
commit | 715e944f8a7a1059db5d61ebf197e6f348d747e2 (patch) | |
tree | 704fc67c91e059925e3681b585290992a0527bd9 | |
parent | f3d3eab667de62572376abb1aa26316191c39929 (diff) |
HID: asus: Stop underlying hardware on remove
We are missing a call to hid_hw_stop() on the remove hook.
Among other things this is causing an Oops when (re-)starting GNOME /
upowerd / ... after the module has been already rmmod-ed.
Signed-off-by: Carlo Caione <carlo@endlessm.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r-- | drivers/hid/hid-asus.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 101ab2e63d18..a6268f2f7408 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c | |||
@@ -537,6 +537,8 @@ static void asus_remove(struct hid_device *hdev) | |||
537 | drvdata->kbd_backlight->removed = true; | 537 | drvdata->kbd_backlight->removed = true; |
538 | cancel_work_sync(&drvdata->kbd_backlight->work); | 538 | cancel_work_sync(&drvdata->kbd_backlight->work); |
539 | } | 539 | } |
540 | |||
541 | hid_hw_stop(hdev); | ||
540 | } | 542 | } |
541 | 543 | ||
542 | static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc, | 544 | static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc, |