diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2018-05-14 09:33:14 -0400 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2018-05-22 04:31:52 -0400 |
| commit | 7124330dabe5b3cb3bdfaa31cf584e1709b16fc3 (patch) | |
| tree | 4dcccd2768987e68e1f076606be835f962e1f7dc | |
| parent | d8441ba80c55aad435e4b98fe0d7ad5d21e46bf9 (diff) | |
m68k/uaccess: Revive 64-bit get_user()
Revive support for 64-bit get_user(), which was disabled in commit
d94af931af42152e ("[PATCH] m68k: clean up uaccess.h") due to a "broken"
typeof in (then brand new) gcc-4.1.
- Keep on using u64 for the temporary, as __typeof__() doesn't drop
the const qualifier,
- Move it into a union (like mips32 does) to get rid of the cast, as
using get_user() to fetch a __user pointer would cause a "cast to
pointer from integer of different size" warning otherwise.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Martijn Coenen <maco@android.com>
| -rw-r--r-- | arch/m68k/include/asm/uaccess_mm.h | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/arch/m68k/include/asm/uaccess_mm.h b/arch/m68k/include/asm/uaccess_mm.h index 75c172e909ac..c4cb889660aa 100644 --- a/arch/m68k/include/asm/uaccess_mm.h +++ b/arch/m68k/include/asm/uaccess_mm.h | |||
| @@ -141,10 +141,12 @@ asm volatile ("\n" \ | |||
| 141 | case 4: \ | 141 | case 4: \ |
| 142 | __get_user_asm(__gu_err, x, ptr, u32, l, r, -EFAULT); \ | 142 | __get_user_asm(__gu_err, x, ptr, u32, l, r, -EFAULT); \ |
| 143 | break; \ | 143 | break; \ |
| 144 | /* case 8: disabled because gcc-4.1 has a broken typeof \ | 144 | case 8: { \ |
| 145 | { \ | 145 | const void *__gu_ptr = (ptr); \ |
| 146 | const void *__gu_ptr = (ptr); \ | 146 | union { \ |
| 147 | u64 __gu_val; \ | 147 | u64 l; \ |
| 148 | __typeof__(*(ptr)) t; \ | ||
| 149 | } __gu_val; \ | ||
| 148 | asm volatile ("\n" \ | 150 | asm volatile ("\n" \ |
| 149 | "1: "MOVES".l (%2)+,%1\n" \ | 151 | "1: "MOVES".l (%2)+,%1\n" \ |
| 150 | "2: "MOVES".l (%2),%R1\n" \ | 152 | "2: "MOVES".l (%2),%R1\n" \ |
| @@ -162,13 +164,13 @@ asm volatile ("\n" \ | |||
| 162 | " .long 1b,10b\n" \ | 164 | " .long 1b,10b\n" \ |
| 163 | " .long 2b,10b\n" \ | 165 | " .long 2b,10b\n" \ |
| 164 | " .previous" \ | 166 | " .previous" \ |
| 165 | : "+d" (__gu_err), "=&r" (__gu_val), \ | 167 | : "+d" (__gu_err), "=&r" (__gu_val.l), \ |
| 166 | "+a" (__gu_ptr) \ | 168 | "+a" (__gu_ptr) \ |
| 167 | : "i" (-EFAULT) \ | 169 | : "i" (-EFAULT) \ |
| 168 | : "memory"); \ | 170 | : "memory"); \ |
| 169 | (x) = (__force typeof(*(ptr)))__gu_val; \ | 171 | (x) = __gu_val.t; \ |
| 170 | break; \ | 172 | break; \ |
| 171 | } */ \ | 173 | } \ |
| 172 | default: \ | 174 | default: \ |
| 173 | __gu_err = __get_user_bad(); \ | 175 | __gu_err = __get_user_bad(); \ |
| 174 | break; \ | 176 | break; \ |
