aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjorn Andersson <bjorn.andersson@linaro.org>2019-05-23 11:01:53 -0400
committerBjorn Andersson <bjorn.andersson@linaro.org>2019-06-15 03:03:44 -0400
commit70d22b78d3235303555c921246e3c1ec37b0a29c (patch)
tree50710386766e34ed39c3357b14f3dc41338e47a4
parent6b9d226b8495deff2e1e702f0ad6cdbb228f3b27 (diff)
soc: qcom: apr: Don't use reg for domain id
The reg property represents the address and size on the bus that a device lives, but for APR the parent is a rpmsg bus, which does not have numerical addresses. Simply defining #address/#size-cells to 1 and 0, respectively, to silence the compiler is not an appropriate solution. Replace the use of "reg" with an APR specific property. Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
-rw-r--r--Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt6
-rw-r--r--drivers/soc/qcom/apr.c2
2 files changed, 4 insertions, 4 deletions
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
index bcc612cc7423..db501269f47b 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
@@ -9,7 +9,7 @@ used for audio/voice services on the QDSP.
9 Value type: <stringlist> 9 Value type: <stringlist>
10 Definition: must be "qcom,apr-v<VERSION-NUMBER>", example "qcom,apr-v2" 10 Definition: must be "qcom,apr-v<VERSION-NUMBER>", example "qcom,apr-v2"
11 11
12- reg 12- qcom,apr-domain
13 Usage: required 13 Usage: required
14 Value type: <u32> 14 Value type: <u32>
15 Definition: Destination processor ID. 15 Definition: Destination processor ID.
@@ -49,9 +49,9 @@ by the individual bindings for the specific service
49The following example represents a QDSP based sound card on a MSM8996 device 49The following example represents a QDSP based sound card on a MSM8996 device
50which uses apr as communication between Apps and QDSP. 50which uses apr as communication between Apps and QDSP.
51 51
52 apr@4 { 52 apr {
53 compatible = "qcom,apr-v2"; 53 compatible = "qcom,apr-v2";
54 reg = <APR_DOMAIN_ADSP>; 54 qcom,apr-domain = <APR_DOMAIN_ADSP>;
55 55
56 q6core@3 { 56 q6core@3 {
57 compatible = "qcom,q6core"; 57 compatible = "qcom,q6core";
diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
index 039e3aa6f5e0..4fcc32420c47 100644
--- a/drivers/soc/qcom/apr.c
+++ b/drivers/soc/qcom/apr.c
@@ -328,7 +328,7 @@ static int apr_probe(struct rpmsg_device *rpdev)
328 if (!apr) 328 if (!apr)
329 return -ENOMEM; 329 return -ENOMEM;
330 330
331 ret = of_property_read_u32(dev->of_node, "reg", &apr->dest_domain_id); 331 ret = of_property_read_u32(dev->of_node, "qcom,apr-domain", &apr->dest_domain_id);
332 if (ret) { 332 if (ret) {
333 dev_err(dev, "APR Domain ID not specified in DT\n"); 333 dev_err(dev, "APR Domain ID not specified in DT\n");
334 return ret; 334 return ret;