diff options
author | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2015-07-09 14:11:51 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.com> | 2015-07-13 07:16:37 -0400 |
commit | 70caee0a3721956a98cb4bfbfa0eaa38c9182e44 (patch) | |
tree | 632c11066d3da5c020e9ffdfb1a30602b6e10e47 | |
parent | 67db8a8086e9b865533348954f5547f1e433101e (diff) |
HID: wacom: remove the extra Pen interface for Wacom Bamboo PAD
As mentioned in the comment in the code, both the pen and touch data
come from the interface tagged as BAMBOO_PAD. The driver re-routes the
events for the Pen to the generic HID interface and keeps the ones for
the touch through this current interface.
Clearing the WACOM_DEVICETYPE_PEN bit removes the extra unused interface
added in 2a6cdbd ("HID: wacom: Introduce new 'touch_input' device") and
makes the Bamboo PAD to behave like in 4.1.
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
-rw-r--r-- | drivers/hid/wacom_wac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 232da89f4e88..f5a0d3c64520 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c | |||
@@ -2220,10 +2220,10 @@ void wacom_setup_device_quirks(struct wacom *wacom) | |||
2220 | * 0, whose HID descriptor has an application usage of 0xFF0D | 2220 | * 0, whose HID descriptor has an application usage of 0xFF0D |
2221 | * (i.e., WACOM_VENDORDEFINED_PEN). We route pen packets back | 2221 | * (i.e., WACOM_VENDORDEFINED_PEN). We route pen packets back |
2222 | * out through the HID_GENERIC device created for interface 1, | 2222 | * out through the HID_GENERIC device created for interface 1, |
2223 | * so rewrite this one to be of type BTN_TOOL_FINGER. | 2223 | * so rewrite this one to be of type WACOM_DEVICETYPE_TOUCH. |
2224 | */ | 2224 | */ |
2225 | if (features->type == BAMBOO_PAD) | 2225 | if (features->type == BAMBOO_PAD) |
2226 | features->device_type |= WACOM_DEVICETYPE_TOUCH; | 2226 | features->device_type = WACOM_DEVICETYPE_TOUCH; |
2227 | 2227 | ||
2228 | if (wacom->hdev->bus == BUS_BLUETOOTH) | 2228 | if (wacom->hdev->bus == BUS_BLUETOOTH) |
2229 | features->quirks |= WACOM_QUIRK_BATTERY; | 2229 | features->quirks |= WACOM_QUIRK_BATTERY; |