aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmil Velikov <emil.velikov@collabora.com>2019-05-27 04:17:37 -0400
committerEmil Velikov <emil.l.velikov@gmail.com>2019-06-26 10:00:40 -0400
commit7042a33deb1411523c88e98d8e79ac7399fdee4c (patch)
treebd4a2756d52b7fced7535d4dc81423af65ea933d
parenta305f6c5c8194fbe53e2f1c101476373d04538d0 (diff)
drm/omap: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls
The authentication can be circumvented, by design, by using the render node. From the driver POV there is no distinction between primary and render nodes, thus we can drop the token. Note: the outstanding DRM_AUTH instance is: - (badly coped) legacy DRI1 ioctl, which is a noop Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Emil Velikov <emil.velikov@collabora.com> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190527081741.14235-9-emil.l.velikov@gmail.com
-rw-r--r--drivers/gpu/drm/omapdrm/omap_drv.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 5929f8688e5a..7bd2da5eb1ce 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -477,19 +477,19 @@ static int ioctl_gem_info(struct drm_device *dev, void *data,
477 477
478static const struct drm_ioctl_desc ioctls[DRM_COMMAND_END - DRM_COMMAND_BASE] = { 478static const struct drm_ioctl_desc ioctls[DRM_COMMAND_END - DRM_COMMAND_BASE] = {
479 DRM_IOCTL_DEF_DRV(OMAP_GET_PARAM, ioctl_get_param, 479 DRM_IOCTL_DEF_DRV(OMAP_GET_PARAM, ioctl_get_param,
480 DRM_AUTH | DRM_RENDER_ALLOW), 480 DRM_RENDER_ALLOW),
481 DRM_IOCTL_DEF_DRV(OMAP_SET_PARAM, drm_invalid_op, 481 DRM_IOCTL_DEF_DRV(OMAP_SET_PARAM, drm_invalid_op,
482 DRM_AUTH | DRM_MASTER | DRM_ROOT_ONLY), 482 DRM_AUTH | DRM_MASTER | DRM_ROOT_ONLY),
483 DRM_IOCTL_DEF_DRV(OMAP_GEM_NEW, ioctl_gem_new, 483 DRM_IOCTL_DEF_DRV(OMAP_GEM_NEW, ioctl_gem_new,
484 DRM_AUTH | DRM_RENDER_ALLOW), 484 DRM_RENDER_ALLOW),
485 /* Deprecated, to be removed. */ 485 /* Deprecated, to be removed. */
486 DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_PREP, drm_noop, 486 DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_PREP, drm_noop,
487 DRM_AUTH | DRM_RENDER_ALLOW), 487 DRM_RENDER_ALLOW),
488 /* Deprecated, to be removed. */ 488 /* Deprecated, to be removed. */
489 DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_FINI, drm_noop, 489 DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_FINI, drm_noop,
490 DRM_AUTH | DRM_RENDER_ALLOW), 490 DRM_RENDER_ALLOW),
491 DRM_IOCTL_DEF_DRV(OMAP_GEM_INFO, ioctl_gem_info, 491 DRM_IOCTL_DEF_DRV(OMAP_GEM_INFO, ioctl_gem_info,
492 DRM_AUTH | DRM_RENDER_ALLOW), 492 DRM_RENDER_ALLOW),
493}; 493};
494 494
495/* 495/*