hwrng: chaoskey - drop workaround for old hwrng core limitation

The hwrng core used to mask 'quality' with 1023; that has been removed
in commit 506bf0c0464ace57169aadcf02ae397999c57bdd ("hwrng: core - allow
perfect entropy from hardware devices"), so we can now just set quality
to 1024.

Signed-off-by: Julien Cristau <jcristau@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 1 insertions, 13 deletions

diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index 6ddd08a32777..aa350dc9eb25 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -215,19 +215,7 @@ static int chaoskey_probe(struct usb_interface *interface,
 
         dev->hwrng.name = dev->name ? dev->name : chaoskey_driver.name;
         dev->hwrng.read = chaoskey_rng_read;
-
-        /* Set the 'quality' metric.  Quality is measured in units of
-         * 1/1024's of a bit ("mills"). This should be set to 1024,
-         * but there is a bug in the hwrng core which masks it with
-         * 1023.
-         *
-         * The patch that has been merged to the crypto development
-         * tree for that bug limits the value to 1024 at most, so by
-         * setting this to 1024 + 1023, we get 1023 before the fix is
-         * merged and 1024 afterwards. We'll patch this driver once
-         * both bits of code are in the same tree.
-         */
-        dev->hwrng.quality = 1024 + 1023;
+        dev->hwrng.quality = 1024;
 
         dev->hwrng_registered = (hwrng_register(&dev->hwrng) == 0);
         if (!dev->hwrng_registered)