diff options
author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2018-06-18 08:33:38 -0400 |
---|---|---|
committer | Bjorn Andersson <bjorn.andersson@linaro.org> | 2018-07-31 02:21:53 -0400 |
commit | 6f0b9584275a5f7756182e0ac39af7bfde9fbf61 (patch) | |
tree | ad1d4812868012290da85440e9e177ef04b62b12 | |
parent | 427613ee193b72eb4b74412db07f43a7508b2bee (diff) |
rpmsg: glink: Fix various kerneldoc warnings.
Fix below kerneldoc warnings while building with W=1
qcom_glink_native.c:53: warning: Function parameter or member 'data' not described in 'glink_defer_cmd'
qcom_glink_native.c:75: warning: Function parameter or member 'data' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'id' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'size' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'reuse' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'in_use' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'offset' not described in 'glink_core_rx_intent'
qcom_glink_native.c:75: warning: Function parameter or member 'node' not described in 'glink_core_rx_intent'
qcom_glink_native.c:116: warning: Function parameter or member 'features' not described in 'qcom_glink'
qcom_glink_native.c:116: warning: Function parameter or member 'intentless' not described in 'qcom_glink'
qcom_glink_native.c:524: warning: Function parameter or member 'version' not described in 'qcom_glink_receive_version'
qcom_glink_native.c:524: warning: Function parameter or member 'features' not described in 'qcom_glink_receive_version'
qcom_glink_native.c:524: warning: Excess function parameter 'r_version' description in 'qcom_glink_receive_version'
qcom_glink_native.c:524: warning: Excess function parameter 'r_features' description in 'qcom_glink_receive_version'
qcom_glink_native.c:551: warning: Function parameter or member 'version' not described in 'qcom_glink_receive_version_ack'
qcom_glink_native.c:551: warning: Function parameter or member 'features' not described in 'qcom_glink_receive_version_ack'
qcom_glink_native.c:551: warning: Excess function parameter 'r_version' description in 'qcom_glink_receive_version_ack'
qcom_glink_native.c:551: warning: Excess function parameter 'r_features' description in 'qcom_glink_receive_version_ack'
qcom_glink_native.c:570: warning: bad line: wire format and transmit
qcom_glink_native.c:604: warning: Function parameter or member 'intent' not described in 'qcom_glink_advertise_intent'
qcom_glink_native.c:604: warning: Excess function parameter 'size' description in 'qcom_glink_advertise_intent'
qcom_glink_native.c:710: warning: Function parameter or member 'glink' not described in 'qcom_glink_handle_intent_req'
qcom_glink_native.c:710: warning: Function parameter or member 'cid' not described in 'qcom_glink_handle_intent_req'
qcom_glink_native.c:710: warning: Function parameter or member 'size' not described in 'qcom_glink_handle_intent_req'
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
-rw-r--r-- | drivers/rpmsg/qcom_glink_native.c | 35 |
1 files changed, 19 insertions, 16 deletions
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index e4eb5a1f417a..df1d923c0db5 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c | |||
@@ -40,7 +40,7 @@ struct glink_msg { | |||
40 | * struct glink_defer_cmd - deferred incoming control message | 40 | * struct glink_defer_cmd - deferred incoming control message |
41 | * @node: list node | 41 | * @node: list node |
42 | * @msg: message header | 42 | * @msg: message header |
43 | * data: payload of the message | 43 | * @data: payload of the message |
44 | * | 44 | * |
45 | * Copy of a received control message, to be added to @rx_queue and processed | 45 | * Copy of a received control message, to be added to @rx_queue and processed |
46 | * by @rx_work of @qcom_glink. | 46 | * by @rx_work of @qcom_glink. |
@@ -56,12 +56,13 @@ struct glink_defer_cmd { | |||
56 | * struct glink_core_rx_intent - RX intent | 56 | * struct glink_core_rx_intent - RX intent |
57 | * RX intent | 57 | * RX intent |
58 | * | 58 | * |
59 | * data: pointer to the data (may be NULL for zero-copy) | 59 | * @data: pointer to the data (may be NULL for zero-copy) |
60 | * id: remote or local intent ID | 60 | * @id: remote or local intent ID |
61 | * size: size of the original intent (do not modify) | 61 | * @size: size of the original intent (do not modify) |
62 | * reuse: To mark if the intent can be reused after first use | 62 | * @reuse: To mark if the intent can be reused after first use |
63 | * in_use: To mark if intent is already in use for the channel | 63 | * @in_use: To mark if intent is already in use for the channel |
64 | * offset: next write offset (initially 0) | 64 | * @offset: next write offset (initially 0) |
65 | * @node: list node | ||
65 | */ | 66 | */ |
66 | struct glink_core_rx_intent { | 67 | struct glink_core_rx_intent { |
67 | void *data; | 68 | void *data; |
@@ -89,6 +90,8 @@ struct glink_core_rx_intent { | |||
89 | * @idr_lock: synchronizes @lcids and @rcids modifications | 90 | * @idr_lock: synchronizes @lcids and @rcids modifications |
90 | * @lcids: idr of all channels with a known local channel id | 91 | * @lcids: idr of all channels with a known local channel id |
91 | * @rcids: idr of all channels with a known remote channel id | 92 | * @rcids: idr of all channels with a known remote channel id |
93 | * @features: remote features | ||
94 | * @intentless: flag to indicate that there is no intent | ||
92 | */ | 95 | */ |
93 | struct qcom_glink { | 96 | struct qcom_glink { |
94 | struct device *dev; | 97 | struct device *dev; |
@@ -512,8 +515,8 @@ static void qcom_glink_rx_done(struct qcom_glink *glink, | |||
512 | * qcom_glink_receive_version() - receive version/features from remote system | 515 | * qcom_glink_receive_version() - receive version/features from remote system |
513 | * | 516 | * |
514 | * @glink: pointer to transport interface | 517 | * @glink: pointer to transport interface |
515 | * @r_version: remote version | 518 | * @version: remote version |
516 | * @r_features: remote features | 519 | * @features: remote features |
517 | * | 520 | * |
518 | * This function is called in response to a remote-initiated version/feature | 521 | * This function is called in response to a remote-initiated version/feature |
519 | * negotiation sequence. | 522 | * negotiation sequence. |
@@ -538,8 +541,8 @@ static void qcom_glink_receive_version(struct qcom_glink *glink, | |||
538 | * qcom_glink_receive_version_ack() - receive negotiation ack from remote system | 541 | * qcom_glink_receive_version_ack() - receive negotiation ack from remote system |
539 | * | 542 | * |
540 | * @glink: pointer to transport interface | 543 | * @glink: pointer to transport interface |
541 | * @r_version: remote version response | 544 | * @version: remote version response |
542 | * @r_features: remote features response | 545 | * @features: remote features response |
543 | * | 546 | * |
544 | * This function is called in response to a local-initiated version/feature | 547 | * This function is called in response to a local-initiated version/feature |
545 | * negotiation sequence and is the counter-offer from the remote side based | 548 | * negotiation sequence and is the counter-offer from the remote side based |
@@ -567,7 +570,7 @@ static void qcom_glink_receive_version_ack(struct qcom_glink *glink, | |||
567 | 570 | ||
568 | /** | 571 | /** |
569 | * qcom_glink_send_intent_req_ack() - convert an rx intent request ack cmd to | 572 | * qcom_glink_send_intent_req_ack() - convert an rx intent request ack cmd to |
570 | wire format and transmit | 573 | * wire format and transmit |
571 | * @glink: The transport to transmit on. | 574 | * @glink: The transport to transmit on. |
572 | * @channel: The glink channel | 575 | * @channel: The glink channel |
573 | * @granted: The request response to encode. | 576 | * @granted: The request response to encode. |
@@ -594,7 +597,7 @@ static int qcom_glink_send_intent_req_ack(struct qcom_glink *glink, | |||
594 | * transmit | 597 | * transmit |
595 | * @glink: The transport to transmit on. | 598 | * @glink: The transport to transmit on. |
596 | * @channel: The local channel | 599 | * @channel: The local channel |
597 | * @size: The intent to pass on to remote. | 600 | * @intent: The intent to pass on to remote. |
598 | * | 601 | * |
599 | * Return: 0 on success or standard Linux error code. | 602 | * Return: 0 on success or standard Linux error code. |
600 | */ | 603 | */ |
@@ -698,9 +701,9 @@ static void qcom_glink_handle_rx_done(struct qcom_glink *glink, | |||
698 | /** | 701 | /** |
699 | * qcom_glink_handle_intent_req() - Receive a request for rx_intent | 702 | * qcom_glink_handle_intent_req() - Receive a request for rx_intent |
700 | * from remote side | 703 | * from remote side |
701 | * if_ptr: Pointer to the transport interface | 704 | * @glink: Pointer to the transport interface |
702 | * rcid: Remote channel ID | 705 | * @cid: Remote channel ID |
703 | * size: size of the intent | 706 | * @size: size of the intent |
704 | * | 707 | * |
705 | * The function searches for the local channel to which the request for | 708 | * The function searches for the local channel to which the request for |
706 | * rx_intent has arrived and allocates and notifies the remote back | 709 | * rx_intent has arrived and allocates and notifies the remote back |