diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-04-02 00:45:01 -0400 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-04-04 03:49:12 -0400 |
| commit | 6edac6fde59e231bd297ebcbc3d1bd395006cd1d (patch) | |
| tree | 492878f8c2df2b2418b4fa3581a1ef7ff2ff8fcb | |
| parent | 85d08340c3de1126467db4e69140fe483d91c114 (diff) | |
HID: hidraw: silence an uninitialized variable warning
My static checker complains that "devid" can be uninitialized if
alloc_chrdev_region() fails. Fix this by moving the error hanling
forward a couple lines.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/hidraw.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 9c2d7c23f296..4b981fd324e8 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c | |||
| @@ -587,14 +587,13 @@ int __init hidraw_init(void) | |||
| 587 | 587 | ||
| 588 | result = alloc_chrdev_region(&dev_id, HIDRAW_FIRST_MINOR, | 588 | result = alloc_chrdev_region(&dev_id, HIDRAW_FIRST_MINOR, |
| 589 | HIDRAW_MAX_DEVICES, "hidraw"); | 589 | HIDRAW_MAX_DEVICES, "hidraw"); |
| 590 | |||
| 591 | hidraw_major = MAJOR(dev_id); | ||
| 592 | |||
| 593 | if (result < 0) { | 590 | if (result < 0) { |
| 594 | pr_warn("can't get major number\n"); | 591 | pr_warn("can't get major number\n"); |
| 595 | goto out; | 592 | goto out; |
| 596 | } | 593 | } |
| 597 | 594 | ||
| 595 | hidraw_major = MAJOR(dev_id); | ||
| 596 | |||
| 598 | hidraw_class = class_create(THIS_MODULE, "hidraw"); | 597 | hidraw_class = class_create(THIS_MODULE, "hidraw"); |
| 599 | if (IS_ERR(hidraw_class)) { | 598 | if (IS_ERR(hidraw_class)) { |
| 600 | result = PTR_ERR(hidraw_class); | 599 | result = PTR_ERR(hidraw_class); |
