diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2014-07-14 08:37:09 -0400 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-07-21 07:43:56 -0400 |
| commit | 6d6b20b2e9498371573c3b24a3e6b4ee1343359b (patch) | |
| tree | 241864196c28650efd749c8d419a3e46f7a19b24 | |
| parent | 8ab58e8e7e097bae5fe39cbc67eb93a91f7134b7 (diff) | |
ACPI: move models with win8 brightness problems from win8 blacklist to use_native_backlight
When the windows8 related backlight problems became evident, 2 approaches
were follow in parallel, one was to stop claiming to be windows 8 / 2012,
the other was to tell acpi_video to stop registering a backlight driver.
I've read all the threads and it seems that which approach ended up being
applied to which model laptop was never really a concious decision (AFAIK):
https://bugzilla.kernel.org/show_bug.cgi?id=51231
https://bugzilla.kernel.org/show_bug.cgi?id=60682
So lets move all the models which are only on the win8 blacklist because of
brightness issues to the use_native_backlight list, which is the smaller
hammer to use to solve the backlight issues.
Making this change is esp. attractive now that 3.16 has
video.use_native_brightness=1 by default. If that new default does not get
reverted because of regressions, then we can drop all the models
with a use_native_backlight quirk, greatly reducing the number of models we've
a quirk for.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=51231
Link: https://bugzilla.kernel.org/show_bug.cgi?id=60682
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/blacklist.c | 68 | ||||
| -rw-r--r-- | drivers/acpi/video.c | 68 |
2 files changed, 68 insertions, 68 deletions
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 3d8413d02a97..36eb42e3b0bb 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c | |||
| @@ -247,75 +247,11 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { | |||
| 247 | }, | 247 | }, |
| 248 | 248 | ||
| 249 | /* | 249 | /* |
| 250 | * The following machines have broken backlight support when reporting | 250 | * These machines will power on immediately after shutdown when |
| 251 | * the Windows 2012 OSI, so disable it until their support is fixed. | 251 | * reporting the Windows 2012 OSI. |
| 252 | */ | 252 | */ |
| 253 | { | 253 | { |
| 254 | .callback = dmi_disable_osi_win8, | 254 | .callback = dmi_disable_osi_win8, |
| 255 | .ident = "ASUS Zenbook Prime UX31A", | ||
| 256 | .matches = { | ||
| 257 | DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), | ||
| 258 | DMI_MATCH(DMI_PRODUCT_NAME, "UX31A"), | ||
| 259 | }, | ||
| 260 | }, | ||
| 261 | { | ||
| 262 | .callback = dmi_disable_osi_win8, | ||
| 263 | .ident = "ThinkPad Edge E530", | ||
| 264 | .matches = { | ||
| 265 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 266 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259A2G"), | ||
| 267 | }, | ||
| 268 | }, | ||
| 269 | { | ||
| 270 | .callback = dmi_disable_osi_win8, | ||
| 271 | .ident = "ThinkPad Edge E530", | ||
| 272 | .matches = { | ||
| 273 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 274 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259CTO"), | ||
| 275 | }, | ||
| 276 | }, | ||
| 277 | { | ||
| 278 | .callback = dmi_disable_osi_win8, | ||
| 279 | .ident = "ThinkPad Edge E530", | ||
| 280 | .matches = { | ||
| 281 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 282 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259HJG"), | ||
| 283 | }, | ||
| 284 | }, | ||
| 285 | { | ||
| 286 | .callback = dmi_disable_osi_win8, | ||
| 287 | .ident = "Acer Aspire V5-573G", | ||
| 288 | .matches = { | ||
| 289 | DMI_MATCH(DMI_SYS_VENDOR, "Acer Aspire"), | ||
| 290 | DMI_MATCH(DMI_PRODUCT_VERSION, "V5-573G/Dazzle_HW"), | ||
| 291 | }, | ||
| 292 | }, | ||
| 293 | { | ||
| 294 | .callback = dmi_disable_osi_win8, | ||
| 295 | .ident = "Acer Aspire V5-572G", | ||
| 296 | .matches = { | ||
| 297 | DMI_MATCH(DMI_SYS_VENDOR, "Acer Aspire"), | ||
| 298 | DMI_MATCH(DMI_PRODUCT_VERSION, "V5-572G/Dazzle_CX"), | ||
| 299 | }, | ||
| 300 | }, | ||
| 301 | { | ||
| 302 | .callback = dmi_disable_osi_win8, | ||
| 303 | .ident = "ThinkPad T431s", | ||
| 304 | .matches = { | ||
| 305 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 306 | DMI_MATCH(DMI_PRODUCT_VERSION, "20AACTO1WW"), | ||
| 307 | }, | ||
| 308 | }, | ||
| 309 | { | ||
| 310 | .callback = dmi_disable_osi_win8, | ||
| 311 | .ident = "ThinkPad T430", | ||
| 312 | .matches = { | ||
| 313 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 314 | DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"), | ||
| 315 | }, | ||
| 316 | }, | ||
| 317 | { | ||
| 318 | .callback = dmi_disable_osi_win8, | ||
| 319 | .ident = "Dell Inspiron 7737", | 255 | .ident = "Dell Inspiron 7737", |
| 320 | .matches = { | 256 | .matches = { |
| 321 | DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), | 257 | DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), |
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index bfe1fa2fb5d1..18c0e6920eb4 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c | |||
| @@ -463,6 +463,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { | |||
| 463 | }, | 463 | }, |
| 464 | { | 464 | { |
| 465 | .callback = video_set_use_native_backlight, | 465 | .callback = video_set_use_native_backlight, |
| 466 | .ident = "ThinkPad X230", | ||
| 467 | .matches = { | ||
| 468 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 469 | DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"), | ||
| 470 | }, | ||
| 471 | }, | ||
| 472 | { | ||
| 473 | .callback = video_set_use_native_backlight, | ||
| 466 | .ident = "ThinkPad T430 and T430s", | 474 | .ident = "ThinkPad T430 and T430s", |
| 467 | .matches = { | 475 | .matches = { |
| 468 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | 476 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), |
| @@ -471,10 +479,42 @@ static struct dmi_system_id video_dmi_table[] __initdata = { | |||
| 471 | }, | 479 | }, |
| 472 | { | 480 | { |
| 473 | .callback = video_set_use_native_backlight, | 481 | .callback = video_set_use_native_backlight, |
| 474 | .ident = "ThinkPad X230", | 482 | .ident = "ThinkPad T430", |
| 475 | .matches = { | 483 | .matches = { |
| 476 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | 484 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), |
| 477 | DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"), | 485 | DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"), |
| 486 | }, | ||
| 487 | }, | ||
| 488 | { | ||
| 489 | .callback = video_set_use_native_backlight, | ||
| 490 | .ident = "ThinkPad T431s", | ||
| 491 | .matches = { | ||
| 492 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 493 | DMI_MATCH(DMI_PRODUCT_VERSION, "20AACTO1WW"), | ||
| 494 | }, | ||
| 495 | }, | ||
| 496 | { | ||
| 497 | .callback = video_set_use_native_backlight, | ||
| 498 | .ident = "ThinkPad Edge E530", | ||
| 499 | .matches = { | ||
| 500 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 501 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259A2G"), | ||
| 502 | }, | ||
| 503 | }, | ||
| 504 | { | ||
| 505 | .callback = video_set_use_native_backlight, | ||
| 506 | .ident = "ThinkPad Edge E530", | ||
| 507 | .matches = { | ||
| 508 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 509 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259CTO"), | ||
| 510 | }, | ||
| 511 | }, | ||
| 512 | { | ||
| 513 | .callback = video_set_use_native_backlight, | ||
| 514 | .ident = "ThinkPad Edge E530", | ||
| 515 | .matches = { | ||
| 516 | DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), | ||
| 517 | DMI_MATCH(DMI_PRODUCT_VERSION, "3259HJG"), | ||
| 478 | }, | 518 | }, |
| 479 | }, | 519 | }, |
| 480 | { | 520 | { |
| @@ -574,6 +614,30 @@ static struct dmi_system_id video_dmi_table[] __initdata = { | |||
| 574 | }, | 614 | }, |
| 575 | }, | 615 | }, |
| 576 | { | 616 | { |
| 617 | .callback = video_set_use_native_backlight, | ||
| 618 | .ident = "Acer Aspire V5-572G", | ||
| 619 | .matches = { | ||
| 620 | DMI_MATCH(DMI_SYS_VENDOR, "Acer Aspire"), | ||
| 621 | DMI_MATCH(DMI_PRODUCT_VERSION, "V5-572G/Dazzle_CX"), | ||
| 622 | }, | ||
| 623 | }, | ||
| 624 | { | ||
| 625 | .callback = video_set_use_native_backlight, | ||
| 626 | .ident = "Acer Aspire V5-573G", | ||
| 627 | .matches = { | ||
| 628 | DMI_MATCH(DMI_SYS_VENDOR, "Acer Aspire"), | ||
| 629 | DMI_MATCH(DMI_PRODUCT_VERSION, "V5-573G/Dazzle_HW"), | ||
| 630 | }, | ||
| 631 | }, | ||
| 632 | { | ||
| 633 | .callback = video_set_use_native_backlight, | ||
| 634 | .ident = "ASUS Zenbook Prime UX31A", | ||
| 635 | .matches = { | ||
| 636 | DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), | ||
| 637 | DMI_MATCH(DMI_PRODUCT_NAME, "UX31A"), | ||
| 638 | }, | ||
| 639 | }, | ||
| 640 | { | ||
| 577 | .callback = video_set_use_native_backlight, | 641 | .callback = video_set_use_native_backlight, |
| 578 | .ident = "HP ProBook 4340s", | 642 | .ident = "HP ProBook 4340s", |
| 579 | .matches = { | 643 | .matches = { |
