diff options
author | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> | 2016-02-25 06:52:11 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-12 01:09:09 -0500 |
commit | 6d210eef1b31b02ebec37a2ced6e73a1f94aacf1 (patch) | |
tree | 861882e7e79f830d8d0d51ce731cf6db18b84155 | |
parent | c8843b1f1d134f3e14cd357a74c2d1de52ccf884 (diff) |
staging: rdma: hfi1: Remove useless return variables
This patch removes unnecessary return variables and compresses the
return logic.
The coccinelle script that finds and fixes this issue is:
@@ type T; identifier i,f; constant C; @@
- T i;
...when != i
when strict
( return -C;
|
- i =
+ return
f(...);
- return i;
)
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/rdma/hfi1/chip.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index 02ba78ff5ca0..46a1830b509b 100644 --- a/drivers/staging/rdma/hfi1/chip.c +++ b/drivers/staging/rdma/hfi1/chip.c | |||
@@ -1250,11 +1250,8 @@ CNTR_ELEM(#name, \ | |||
1250 | 1250 | ||
1251 | u64 read_csr(const struct hfi1_devdata *dd, u32 offset) | 1251 | u64 read_csr(const struct hfi1_devdata *dd, u32 offset) |
1252 | { | 1252 | { |
1253 | u64 val; | ||
1254 | |||
1255 | if (dd->flags & HFI1_PRESENT) { | 1253 | if (dd->flags & HFI1_PRESENT) { |
1256 | val = readq((void __iomem *)dd->kregbase + offset); | 1254 | return readq((void __iomem *)dd->kregbase + offset); |
1257 | return val; | ||
1258 | } | 1255 | } |
1259 | return -1; | 1256 | return -1; |
1260 | } | 1257 | } |