aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-10-17 10:31:51 -0400
committerJiri Kosina <jkosina@suse.cz>2017-10-19 07:52:38 -0400
commit6cb6d98abdb06de867e34fde92912fdb89477897 (patch)
treed0ff26c6d5f20599cb606849de471ecd58329699
parent47af1cdb309c65b36230b44e77383ed53b503d0e (diff)
HID: hid-logitech: remove redundant assignment to pointer value
The pointer value is being assigned a value and this is never read, and later on it is being assigned a new value. This the first assignment is redundant and can be removed and hence also the variables report and report_list. Cleans up the clang warning: Value stored to 'value' during its initialization is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-lg4ff.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index 1fc12e357035..512d67e1aae3 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -474,9 +474,7 @@ static int lg4ff_play(struct input_dev *dev, void *data, struct ff_effect *effec
474static void lg4ff_set_autocenter_default(struct input_dev *dev, u16 magnitude) 474static void lg4ff_set_autocenter_default(struct input_dev *dev, u16 magnitude)
475{ 475{
476 struct hid_device *hid = input_get_drvdata(dev); 476 struct hid_device *hid = input_get_drvdata(dev);
477 struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list; 477 s32 *value;
478 struct hid_report *report = list_entry(report_list->next, struct hid_report, list);
479 s32 *value = report->field[0]->value;
480 u32 expand_a, expand_b; 478 u32 expand_a, expand_b;
481 struct lg4ff_device_entry *entry; 479 struct lg4ff_device_entry *entry;
482 struct lg_drv_data *drv_data; 480 struct lg_drv_data *drv_data;