aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarek Szyprowski <m.szyprowski@samsung.com>2016-05-09 12:31:47 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-05-09 12:33:33 -0400
commit6ae645d5fa385f3787bf1723639cd907fe5865e7 (patch)
treefd40e2bc89abeb71978044dd68d9354ac61a82b1
parent82aaa086019ce0e6fcd3a44c0a2e4329afe988b6 (diff)
Input: max8997-haptic - fix NULL pointer dereference
NULL pointer derefence happens when booting with DTB because the platform data for haptic device is not set in supplied data from parent MFD device. The MFD device creates only platform data (from Device Tree) for itself, not for haptic child. Unable to handle kernel NULL pointer dereference at virtual address 0000009c pgd = c0004000 [0000009c] *pgd=00000000 Internal error: Oops: 5 [#1] PREEMPT SMP ARM (max8997_haptic_probe) from [<c03f9cec>] (platform_drv_probe+0x4c/0xb0) (platform_drv_probe) from [<c03f8440>] (driver_probe_device+0x214/0x2c0) (driver_probe_device) from [<c03f8598>] (__driver_attach+0xac/0xb0) (__driver_attach) from [<c03f67ac>] (bus_for_each_dev+0x68/0x9c) (bus_for_each_dev) from [<c03f7a38>] (bus_add_driver+0x1a0/0x218) (bus_add_driver) from [<c03f8db0>] (driver_register+0x78/0xf8) (driver_register) from [<c0101774>] (do_one_initcall+0x90/0x1d8) (do_one_initcall) from [<c0a00dbc>] (kernel_init_freeable+0x15c/0x1fc) (kernel_init_freeable) from [<c06bb5b4>] (kernel_init+0x8/0x114) (kernel_init) from [<c0107938>] (ret_from_fork+0x14/0x3c) Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Cc: <stable@vger.kernel.org> Fixes: 104594b01ce7 ("Input: add driver support for MAX8997-haptic") [k.kozlowski: Write commit message, add CC-stable] Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/misc/max8997_haptic.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
index a806ba3818f7..8d6326d7e7be 100644
--- a/drivers/input/misc/max8997_haptic.c
+++ b/drivers/input/misc/max8997_haptic.c
@@ -255,12 +255,14 @@ static int max8997_haptic_probe(struct platform_device *pdev)
255 struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent); 255 struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent);
256 const struct max8997_platform_data *pdata = 256 const struct max8997_platform_data *pdata =
257 dev_get_platdata(iodev->dev); 257 dev_get_platdata(iodev->dev);
258 const struct max8997_haptic_platform_data *haptic_pdata = 258 const struct max8997_haptic_platform_data *haptic_pdata = NULL;
259 pdata->haptic_pdata;
260 struct max8997_haptic *chip; 259 struct max8997_haptic *chip;
261 struct input_dev *input_dev; 260 struct input_dev *input_dev;
262 int error; 261 int error;
263 262
263 if (pdata)
264 haptic_pdata = pdata->haptic_pdata;
265
264 if (!haptic_pdata) { 266 if (!haptic_pdata) {
265 dev_err(&pdev->dev, "no haptic platform data\n"); 267 dev_err(&pdev->dev, "no haptic platform data\n");
266 return -EINVAL; 268 return -EINVAL;