diff options
author | Bjørn Mork <bjorn@mork.no> | 2017-12-05 12:46:39 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2017-12-12 19:14:54 -0500 |
commit | 6993ce46c910ec83b4a7f064bbf76f254217019c (patch) | |
tree | 43c5ab5213939d241ef95a478d03e9731a3ced13 | |
parent | 50c4c4e268a2d7a3e58ebb698ac74da0de40ae36 (diff) |
ACPI: battery: Drop redundant test for failure
Merging the two adjacent conditionally built blocks makes the code
a lot more readable. And as a bonus, we drop a duplicate test when
CONFIG_ACPI_PROCFS_POWER is undefined.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | drivers/acpi/battery.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 13e7b56e33ae..f2eb6c37ea0a 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c | |||
@@ -1237,13 +1237,11 @@ static int acpi_battery_add(struct acpi_device *device) | |||
1237 | 1237 | ||
1238 | #ifdef CONFIG_ACPI_PROCFS_POWER | 1238 | #ifdef CONFIG_ACPI_PROCFS_POWER |
1239 | result = acpi_battery_add_fs(device); | 1239 | result = acpi_battery_add_fs(device); |
1240 | #endif | ||
1241 | if (result) { | 1240 | if (result) { |
1242 | #ifdef CONFIG_ACPI_PROCFS_POWER | ||
1243 | acpi_battery_remove_fs(device); | 1241 | acpi_battery_remove_fs(device); |
1244 | #endif | ||
1245 | goto fail; | 1242 | goto fail; |
1246 | } | 1243 | } |
1244 | #endif | ||
1247 | 1245 | ||
1248 | printk(KERN_INFO PREFIX "%s Slot [%s] (battery %s)\n", | 1246 | printk(KERN_INFO PREFIX "%s Slot [%s] (battery %s)\n", |
1249 | ACPI_BATTERY_DEVICE_NAME, acpi_device_bid(device), | 1247 | ACPI_BATTERY_DEVICE_NAME, acpi_device_bid(device), |