diff options
author | Johan Hovold <johan@kernel.org> | 2017-10-30 06:35:26 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2017-10-31 07:09:43 -0400 |
commit | 68b892f1fdc493d7cd4e4067596879cd097c1f62 (patch) | |
tree | 2239373187c97df66d42397dd922c113c8a84ffa | |
parent | 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e (diff) |
spi: document odd controller reference handling
Document the fact that a reference to the controller is dropped as part
of deregistration.
This is an odd pattern as the reference is typically taken in
__spi_alloc_controller() rather than spi_register_controller(). Most
controller drivers gets it right these days and notably the
device-managed interface relies on this behaviour.
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/spi/spi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 6e65524cbfd9..5673cca1d1d0 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c | |||
@@ -2195,7 +2195,7 @@ static void devm_spi_unregister(struct device *dev, void *res) | |||
2195 | * Context: can sleep | 2195 | * Context: can sleep |
2196 | * | 2196 | * |
2197 | * Register a SPI device as with spi_register_controller() which will | 2197 | * Register a SPI device as with spi_register_controller() which will |
2198 | * automatically be unregister | 2198 | * automatically be unregistered and freed. |
2199 | * | 2199 | * |
2200 | * Return: zero on success, else a negative error code. | 2200 | * Return: zero on success, else a negative error code. |
2201 | */ | 2201 | */ |
@@ -2236,6 +2236,8 @@ static int __unregister(struct device *dev, void *null) | |||
2236 | * only ones directly touching chip registers. | 2236 | * only ones directly touching chip registers. |
2237 | * | 2237 | * |
2238 | * This must be called from context that can sleep. | 2238 | * This must be called from context that can sleep. |
2239 | * | ||
2240 | * Note that this function also drops a reference to the controller. | ||
2239 | */ | 2241 | */ |
2240 | void spi_unregister_controller(struct spi_controller *ctlr) | 2242 | void spi_unregister_controller(struct spi_controller *ctlr) |
2241 | { | 2243 | { |