aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2013-03-07 07:12:27 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-03-18 19:19:05 -0400
commit6865ff222ccab371c04afce17aec1f7d70b17dbc (patch)
treec5fb3ebecb698f8735e52fd7bdcbcb69e3a99f86
parent049b539b39977fc9343056435eba568fc7779970 (diff)
TTY: do not warn about setting speed via SPD_*
The warning is there since 2.1.69 and we have not seen anybody reporting it in the past decade. Remove the warning now. tty_get_baud_rate can now be inline. This gives us one less EXPORT_SYMBOL. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/tty_ioctl.c28
-rw-r--r--include/linux/tty.h18
2 files changed, 16 insertions, 30 deletions
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 132d452578bb..28715e48b2f7 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -479,34 +479,6 @@ void tty_encode_baud_rate(struct tty_struct *tty, speed_t ibaud, speed_t obaud)
479EXPORT_SYMBOL_GPL(tty_encode_baud_rate); 479EXPORT_SYMBOL_GPL(tty_encode_baud_rate);
480 480
481/** 481/**
482 * tty_get_baud_rate - get tty bit rates
483 * @tty: tty to query
484 *
485 * Returns the baud rate as an integer for this terminal. The
486 * termios lock must be held by the caller and the terminal bit
487 * flags may be updated.
488 *
489 * Locking: none
490 */
491
492speed_t tty_get_baud_rate(struct tty_struct *tty)
493{
494 speed_t baud = tty_termios_baud_rate(&tty->termios);
495
496 if (baud == 38400 && tty->alt_speed) {
497 if (!tty->warned) {
498 printk(KERN_WARNING "Use of setserial/setrocket to "
499 "set SPD_* flags is deprecated\n");
500 tty->warned = 1;
501 }
502 baud = tty->alt_speed;
503 }
504
505 return baud;
506}
507EXPORT_SYMBOL(tty_get_baud_rate);
508
509/**
510 * tty_termios_copy_hw - copy hardware settings 482 * tty_termios_copy_hw - copy hardware settings
511 * @new: New termios 483 * @new: New termios
512 * @old: Old termios 484 * @old: Old termios
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 189ca80494d1..63b62865c8e9 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -255,7 +255,6 @@ struct tty_struct {
255 int count; 255 int count;
256 struct winsize winsize; /* termios mutex */ 256 struct winsize winsize; /* termios mutex */
257 unsigned char stopped:1, hw_stopped:1, flow_stopped:1, packet:1; 257 unsigned char stopped:1, hw_stopped:1, flow_stopped:1, packet:1;
258 unsigned char warned:1;
259 unsigned char ctrl_status; /* ctrl_lock */ 258 unsigned char ctrl_status; /* ctrl_lock */
260 unsigned int receive_room; /* Bytes free for queue */ 259 unsigned int receive_room; /* Bytes free for queue */
261 int flow_change; 260 int flow_change;
@@ -437,13 +436,28 @@ extern void tty_flush_to_ldisc(struct tty_struct *tty);
437extern void tty_buffer_free_all(struct tty_port *port); 436extern void tty_buffer_free_all(struct tty_port *port);
438extern void tty_buffer_flush(struct tty_struct *tty); 437extern void tty_buffer_flush(struct tty_struct *tty);
439extern void tty_buffer_init(struct tty_port *port); 438extern void tty_buffer_init(struct tty_port *port);
440extern speed_t tty_get_baud_rate(struct tty_struct *tty);
441extern speed_t tty_termios_baud_rate(struct ktermios *termios); 439extern speed_t tty_termios_baud_rate(struct ktermios *termios);
442extern speed_t tty_termios_input_baud_rate(struct ktermios *termios); 440extern speed_t tty_termios_input_baud_rate(struct ktermios *termios);
443extern void tty_termios_encode_baud_rate(struct ktermios *termios, 441extern void tty_termios_encode_baud_rate(struct ktermios *termios,
444 speed_t ibaud, speed_t obaud); 442 speed_t ibaud, speed_t obaud);
445extern void tty_encode_baud_rate(struct tty_struct *tty, 443extern void tty_encode_baud_rate(struct tty_struct *tty,
446 speed_t ibaud, speed_t obaud); 444 speed_t ibaud, speed_t obaud);
445
446/**
447 * tty_get_baud_rate - get tty bit rates
448 * @tty: tty to query
449 *
450 * Returns the baud rate as an integer for this terminal. The
451 * termios lock must be held by the caller and the terminal bit
452 * flags may be updated.
453 *
454 * Locking: none
455 */
456static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
457{
458 return tty_termios_baud_rate(&tty->termios);
459}
460
447extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old); 461extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
448extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b); 462extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
449extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt); 463extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);