diff options
author | Rahul Verma <Rahul.Verma@cavium.com> | 2018-10-23 11:04:24 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-10-23 14:04:44 -0400 |
commit | 68203a67a7024c5d0b8e545d3d370b1fec971551 (patch) | |
tree | d628b43e82b799f5b48ee803fb3333bdc19d0d3f | |
parent | 5ef79151c2fbc401cf38325e9a32e77b9fc593ae (diff) |
qed: Fix static checker warning
Static Checker Warnings:
drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability()
error: uninitialized symbol 'tcvr_state'.
drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
error: uninitialized symbol 'transceiver_state'.
drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
error: uninitialized symbol 'transceiver_type'.
Symbols tcvr_state, transceiver_state and transceiver_type
are initialized with respective default state.
Fixes: c56a8be7e7aa ("qed: Add supported link and advertise link to display in ethtool.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rahul Verma <Rahul.Verma@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_mcp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index 386ee5410237..f40f654398a0 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c | |||
@@ -1900,6 +1900,9 @@ int qed_mcp_get_transceiver_data(struct qed_hwfn *p_hwfn, | |||
1900 | { | 1900 | { |
1901 | u32 transceiver_info; | 1901 | u32 transceiver_info; |
1902 | 1902 | ||
1903 | *p_transceiver_type = ETH_TRANSCEIVER_TYPE_NONE; | ||
1904 | *p_transceiver_state = ETH_TRANSCEIVER_STATE_UPDATING; | ||
1905 | |||
1903 | if (IS_VF(p_hwfn->cdev)) | 1906 | if (IS_VF(p_hwfn->cdev)) |
1904 | return -EINVAL; | 1907 | return -EINVAL; |
1905 | 1908 | ||
@@ -1908,9 +1911,6 @@ int qed_mcp_get_transceiver_data(struct qed_hwfn *p_hwfn, | |||
1908 | return -EBUSY; | 1911 | return -EBUSY; |
1909 | } | 1912 | } |
1910 | 1913 | ||
1911 | *p_transceiver_type = ETH_TRANSCEIVER_TYPE_NONE; | ||
1912 | *p_transceiver_state = ETH_TRANSCEIVER_STATE_UPDATING; | ||
1913 | |||
1914 | transceiver_info = qed_rd(p_hwfn, p_ptt, | 1914 | transceiver_info = qed_rd(p_hwfn, p_ptt, |
1915 | p_hwfn->mcp_info->port_addr + | 1915 | p_hwfn->mcp_info->port_addr + |
1916 | offsetof(struct public_port, | 1916 | offsetof(struct public_port, |