diff options
author | Greg Edwards <gedwards@ddn.com> | 2017-10-24 13:21:48 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-11-10 21:55:57 -0500 |
commit | 67f2519fe2903c4041c0e94394d14d372fe51399 (patch) | |
tree | fc98b82e0148eeb551b38084057a6b2bf2ac1e4e | |
parent | 0e78eccc552b6a9e9ce158aee72e95ae41e0e171 (diff) |
fs: guard_bio_eod() needs to consider partitions
guard_bio_eod() needs to look at the partition capacity, not just the
capacity of the whole device, when determining if truncation is
necessary.
[ 60.268688] attempt to access beyond end of device
[ 60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
[ 60.268693] buffer_io_error: 2 callbacks suppressed
[ 60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
Cc: stable@vger.kernel.org # v4.13
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Edwards <gedwards@ddn.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r-- | fs/buffer.c | 10 | ||||
-rw-r--r-- | include/linux/genhd.h | 1 |
2 files changed, 10 insertions, 1 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index bff571dc7bc3..bcabb69e7462 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -3015,8 +3015,16 @@ void guard_bio_eod(int op, struct bio *bio) | |||
3015 | sector_t maxsector; | 3015 | sector_t maxsector; |
3016 | struct bio_vec *bvec = &bio->bi_io_vec[bio->bi_vcnt - 1]; | 3016 | struct bio_vec *bvec = &bio->bi_io_vec[bio->bi_vcnt - 1]; |
3017 | unsigned truncated_bytes; | 3017 | unsigned truncated_bytes; |
3018 | struct hd_struct *part; | ||
3019 | |||
3020 | rcu_read_lock(); | ||
3021 | part = __disk_get_part(bio->bi_disk, bio->bi_partno); | ||
3022 | if (part) | ||
3023 | maxsector = part_nr_sects_read(part); | ||
3024 | else | ||
3025 | maxsector = get_capacity(bio->bi_disk); | ||
3026 | rcu_read_unlock(); | ||
3018 | 3027 | ||
3019 | maxsector = get_capacity(bio->bi_disk); | ||
3020 | if (!maxsector) | 3028 | if (!maxsector) |
3021 | return; | 3029 | return; |
3022 | 3030 | ||
diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 93aae3476f58..ca10cc292187 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h | |||
@@ -243,6 +243,7 @@ static inline dev_t part_devt(struct hd_struct *part) | |||
243 | return part_to_dev(part)->devt; | 243 | return part_to_dev(part)->devt; |
244 | } | 244 | } |
245 | 245 | ||
246 | extern struct hd_struct *__disk_get_part(struct gendisk *disk, int partno); | ||
246 | extern struct hd_struct *disk_get_part(struct gendisk *disk, int partno); | 247 | extern struct hd_struct *disk_get_part(struct gendisk *disk, int partno); |
247 | 248 | ||
248 | static inline void disk_put_part(struct hd_struct *part) | 249 | static inline void disk_put_part(struct hd_struct *part) |