diff options
author | Stefan Raspl <stefan.raspl@de.ibm.com> | 2017-12-11 06:25:21 -0500 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2017-12-14 03:25:42 -0500 |
commit | 67c162b0892ac481e47bef06d9c6231ee993843a (patch) | |
tree | 8e4a6a99382dd223615dcb340de3d2b840f30996 | |
parent | faa06650418bf28d07426fcfdc5213782fb131f6 (diff) |
tools/kvm_stat: fix missing field update after filter change
When updating the fields filter, tracepoint events of fields previously
not visible were not enabled, as TracepointProvider.update_fields()
updated the member variable directly instead of using the setter, which
triggers the event enable/disable.
To reproduce, run 'kvm_stat -f kvm_exit', press 'c' to remove the
filter, and notice that no add'l fields that do not match the regex
'kvm_exit' will appear.
This issue was introduced by commit c469117df059 ("tools/kvm_stat:
simplify initializers").
Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rwxr-xr-x | tools/kvm/kvm_stat/kvm_stat | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat index 6347ad5d0d35..f133755fdde2 100755 --- a/tools/kvm/kvm_stat/kvm_stat +++ b/tools/kvm/kvm_stat/kvm_stat | |||
@@ -549,8 +549,8 @@ class TracepointProvider(Provider): | |||
549 | 549 | ||
550 | def update_fields(self, fields_filter): | 550 | def update_fields(self, fields_filter): |
551 | """Refresh fields, applying fields_filter""" | 551 | """Refresh fields, applying fields_filter""" |
552 | self._fields = [field for field in self.get_available_fields() | 552 | self.fields = [field for field in self.get_available_fields() |
553 | if self.is_field_wanted(fields_filter, field)] | 553 | if self.is_field_wanted(fields_filter, field)] |
554 | 554 | ||
555 | @staticmethod | 555 | @staticmethod |
556 | def get_online_cpus(): | 556 | def get_online_cpus(): |