aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Beulich <JBeulich@suse.com>2018-07-02 06:47:57 -0400
committerIngo Molnar <mingo@kernel.org>2018-07-03 03:59:29 -0400
commit6709812f094d96543b443645c68daaa32d3d3e77 (patch)
tree1bf258827c8f9c60789e3f2d3da3ff026f874a05
parenta7bea8308933aaeea76dad7d42a6e51000417626 (diff)
x86/entry/64: Add two more instruction suffixes
Sadly, other than claimed in: a368d7fd2a ("x86/entry/64: Add instruction suffix") ... there are two more instances which want to be adjusted. As said there, omitting suffixes from instructions in AT&T mode is bad practice when operand size cannot be determined by the assembler from register operands, and is likely going to be warned about by upstream gas in the future (mine does already). Add the other missing suffixes here as well. Signed-off-by: Jan Beulich <jbeulich@suse.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/5B3A02DD02000078001CFB78@prv1-mh.provo.novell.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/entry/entry_64.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index c6f3677e6105..65aa16d845f6 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -92,7 +92,7 @@ END(native_usergs_sysret64)
92.endm 92.endm
93 93
94.macro TRACE_IRQS_IRETQ_DEBUG 94.macro TRACE_IRQS_IRETQ_DEBUG
95 bt $9, EFLAGS(%rsp) /* interrupts off? */ 95 btl $9, EFLAGS(%rsp) /* interrupts off? */
96 jnc 1f 96 jnc 1f
97 TRACE_IRQS_ON_DEBUG 97 TRACE_IRQS_ON_DEBUG
981: 981:
@@ -702,7 +702,7 @@ retint_kernel:
702#ifdef CONFIG_PREEMPT 702#ifdef CONFIG_PREEMPT
703 /* Interrupts are off */ 703 /* Interrupts are off */
704 /* Check if we need preemption */ 704 /* Check if we need preemption */
705 bt $9, EFLAGS(%rsp) /* were interrupts off? */ 705 btl $9, EFLAGS(%rsp) /* were interrupts off? */
706 jnc 1f 706 jnc 1f
7070: cmpl $0, PER_CPU_VAR(__preempt_count) 7070: cmpl $0, PER_CPU_VAR(__preempt_count)
708 jnz 1f 708 jnz 1f