aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Blanchard <anton@samba.org>2017-06-14 19:46:39 -0400
committerMichael Ellerman <mpe@ellerman.id.au>2017-07-12 02:43:48 -0400
commit64e756c55aa46fc18fd53e8f3598b73b528d8637 (patch)
treed068e4650693d6d5b06fc9cfd9042ccec9df7a08
parent87c4b83e0fe234a1f0eed131ab6fa232036860d5 (diff)
powerpc: Fix emulation of mfocrf in emulate_step()
From POWER4 onwards, mfocrf() only places the specified CR field into the destination GPR, and the rest of it is set to 0. The PowerPC AS from version 3.0 now requires this behaviour. The emulation code currently puts the entire CR into the destination GPR. Fix it. Fixes: 6888199f7fe5 ("[POWERPC] Emulate more instructions in software") Cc: stable@vger.kernel.org # v2.6.22+ Signed-off-by: Anton Blanchard <anton@samba.org> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
-rw-r--r--arch/powerpc/lib/sstep.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index fb84f51b1f0b..ee33327686ae 100644
--- a/arch/powerpc/lib/sstep.c
+++ b/arch/powerpc/lib/sstep.c
@@ -966,6 +966,19 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
966#endif 966#endif
967 967
968 case 19: /* mfcr */ 968 case 19: /* mfcr */
969 if ((instr >> 20) & 1) {
970 imm = 0xf0000000UL;
971 for (sh = 0; sh < 8; ++sh) {
972 if (instr & (0x80000 >> sh)) {
973 regs->gpr[rd] = regs->ccr & imm;
974 break;
975 }
976 imm >>= 4;
977 }
978
979 goto instr_done;
980 }
981
969 regs->gpr[rd] = regs->ccr; 982 regs->gpr[rd] = regs->ccr;
970 regs->gpr[rd] &= 0xffffffffUL; 983 regs->gpr[rd] &= 0xffffffffUL;
971 goto instr_done; 984 goto instr_done;