aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorian Fainelli <f.fainelli@gmail.com>2018-10-11 18:06:33 -0400
committerDavid S. Miller <davem@davemloft.net>2018-10-16 01:10:21 -0400
commit64bd9c8135751b561f27edaaffe93d07093f81af (patch)
tree63c938edeb3043479e7ab3b3d0b416345534a45a
parentd6672a5a97918f92bf2f3a2591f25d02bb0897a4 (diff)
net: bcmgenet: Poll internal PHY for GENETv5
On GENETv5, there is a hardware issue which prevents the GENET hardware from generating a link UP interrupt when the link is operating at 10Mbits/sec. Since we do not have any way to configure the link detection logic, fallback to polling in that case. Fixes: 421380856d9c ("net: bcmgenet: add support for the GENETv5 hardware") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmmii.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 4241ae928d4a..34af5f1569c8 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -321,9 +321,12 @@ int bcmgenet_mii_probe(struct net_device *dev)
321 phydev->advertising = phydev->supported; 321 phydev->advertising = phydev->supported;
322 322
323 /* The internal PHY has its link interrupts routed to the 323 /* The internal PHY has its link interrupts routed to the
324 * Ethernet MAC ISRs 324 * Ethernet MAC ISRs. On GENETv5 there is a hardware issue
325 * that prevents the signaling of link UP interrupts when
326 * the link operates at 10Mbps, so fallback to polling for
327 * those versions of GENET.
325 */ 328 */
326 if (priv->internal_phy) 329 if (priv->internal_phy && !GENET_IS_V5(priv))
327 dev->phydev->irq = PHY_IGNORE_INTERRUPT; 330 dev->phydev->irq = PHY_IGNORE_INTERRUPT;
328 331
329 return 0; 332 return 0;