diff options
author | YueHaibing <yuehaibing@huawei.com> | 2018-07-18 22:27:13 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-07-21 19:14:39 -0400 |
commit | 64119e05f7b31e83e2555f6782e6cdc8f81c63f4 (patch) | |
tree | 87d44bf9e7cecbc6fa4cbb7e6d45f8ec32b62b4a | |
parent | c1f897ce186a529a494441642125479d38727a3d (diff) |
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
Add a missing rcu_read_unlock in the error path
Fixes: c95567c80352 ("caif: added check for potential null return")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/caif/caif_dev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index e0adcd123f48..711d7156efd8 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c | |||
@@ -131,8 +131,10 @@ static void caif_flow_cb(struct sk_buff *skb) | |||
131 | caifd = caif_get(skb->dev); | 131 | caifd = caif_get(skb->dev); |
132 | 132 | ||
133 | WARN_ON(caifd == NULL); | 133 | WARN_ON(caifd == NULL); |
134 | if (caifd == NULL) | 134 | if (!caifd) { |
135 | rcu_read_unlock(); | ||
135 | return; | 136 | return; |
137 | } | ||
136 | 138 | ||
137 | caifd_hold(caifd); | 139 | caifd_hold(caifd); |
138 | rcu_read_unlock(); | 140 | rcu_read_unlock(); |