aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Brown <broonie@linaro.org>2013-08-31 06:48:45 -0400
committerMark Brown <broonie@linaro.org>2013-09-16 19:27:53 -0400
commit63fb3149c8ba2b0194ba7e967f2dafc1c8c0da69 (patch)
treeccd3135fc6aeb6634a7ea7f7eec15989d09f53c0
parentb0c4c0c68982156bfb94993305e69a03309395c3 (diff)
regulator: wm831x-isink: Use devm_request_threaded_irq()
devm guarantees that resources are freed in the opposite order to that in which they are allocated. Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--drivers/regulator/wm831x-isink.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/regulator/wm831x-isink.c b/drivers/regulator/wm831x-isink.c
index 4eb373de1fac..841cb52b2bb6 100644
--- a/drivers/regulator/wm831x-isink.c
+++ b/drivers/regulator/wm831x-isink.c
@@ -203,8 +203,10 @@ static int wm831x_isink_probe(struct platform_device *pdev)
203 } 203 }
204 204
205 irq = wm831x_irq(wm831x, platform_get_irq(pdev, 0)); 205 irq = wm831x_irq(wm831x, platform_get_irq(pdev, 0));
206 ret = request_threaded_irq(irq, NULL, wm831x_isink_irq, 206 ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
207 IRQF_TRIGGER_RISING, isink->name, isink); 207 wm831x_isink_irq,
208 IRQF_TRIGGER_RISING, isink->name,
209 isink);
208 if (ret != 0) { 210 if (ret != 0) {
209 dev_err(&pdev->dev, "Failed to request ISINK IRQ %d: %d\n", 211 dev_err(&pdev->dev, "Failed to request ISINK IRQ %d: %d\n",
210 irq, ret); 212 irq, ret);
@@ -225,8 +227,6 @@ static int wm831x_isink_remove(struct platform_device *pdev)
225{ 227{
226 struct wm831x_isink *isink = platform_get_drvdata(pdev); 228 struct wm831x_isink *isink = platform_get_drvdata(pdev);
227 229
228 free_irq(wm831x_irq(isink->wm831x, platform_get_irq(pdev, 0)), isink);
229
230 regulator_unregister(isink->regulator); 230 regulator_unregister(isink->regulator);
231 231
232 return 0; 232 return 0;