diff options
author | Alex Deucher <alexander.deucher@amd.com> | 2018-11-06 16:06:32 -0500 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2018-11-06 16:23:58 -0500 |
commit | 63088da9472854408ae5d7c47bd011daf9e1a81b (patch) | |
tree | 8dc598df6e670f37ce81f6ef38ff594fc278ff9a | |
parent | 86a484bda787d542d4a968bd7742bcf844c8adb2 (diff) |
Revert "drm/amd/display: set backlight level limit to 1"
This reverts commit 0cafc82fae41531b0162150f9a97f2c74f97118f.
This breaks some apps that assume 0 is minimum brightness.
Revert for 4.20. This is fixed properly for drm-next/4.21 in:
"drm/amd: Don't fail on backlight = 0"
However, that patch depends on more extensive changes to the
backlight interface which are too invasive for -fixes.
Fixes: Bugzilla: https://bugs.freedesktop.org/108668
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index b0df6dc9a775..e224f23e2215 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | |||
@@ -1524,13 +1524,6 @@ static int amdgpu_dm_backlight_update_status(struct backlight_device *bd) | |||
1524 | { | 1524 | { |
1525 | struct amdgpu_display_manager *dm = bl_get_data(bd); | 1525 | struct amdgpu_display_manager *dm = bl_get_data(bd); |
1526 | 1526 | ||
1527 | /* | ||
1528 | * PWM interperts 0 as 100% rather than 0% because of HW | ||
1529 | * limitation for level 0.So limiting minimum brightness level | ||
1530 | * to 1. | ||
1531 | */ | ||
1532 | if (bd->props.brightness < 1) | ||
1533 | return 1; | ||
1534 | if (dc_link_set_backlight_level(dm->backlight_link, | 1527 | if (dc_link_set_backlight_level(dm->backlight_link, |
1535 | bd->props.brightness, 0, 0)) | 1528 | bd->props.brightness, 0, 0)) |
1536 | return 0; | 1529 | return 0; |