diff options
| author | Stefan Behrens <sbehrens@giantdisaster.de> | 2012-07-31 13:09:44 -0400 |
|---|---|---|
| committer | Chris Mason <chris.mason@fusionio.com> | 2012-10-09 09:20:10 -0400 |
| commit | 62856a9b73860cffe2a3d91b069393b88c219aa6 (patch) | |
| tree | b8ac52154994875dc4df6aa35171e44b0b24d2aa | |
| parent | bedb2cca7252d08c6ca3085826e30f65bdc3b54b (diff) | |
Btrfs: detect corrupted filesystem after write I/O errors
In check-integrity, detect when a superblock is written that points
to blocks that have not been written to disk due to I/O write errors.
Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
| -rw-r--r-- | fs/btrfs/check-integrity.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 9197e2e33407..5a3e45db642a 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c | |||
| @@ -37,8 +37,9 @@ | |||
| 37 | * the file system was mounted, (i.e., they have been | 37 | * the file system was mounted, (i.e., they have been |
| 38 | * referenced by the super block) or they have been | 38 | * referenced by the super block) or they have been |
| 39 | * written since then and the write completion callback | 39 | * written since then and the write completion callback |
| 40 | * was called and a FLUSH request to the device where | 40 | * was called and no write error was indicated and a |
| 41 | * these blocks are located was received and completed. | 41 | * FLUSH request to the device where these blocks are |
| 42 | * located was received and completed. | ||
| 42 | * 2b. All referenced blocks need to have a generation | 43 | * 2b. All referenced blocks need to have a generation |
| 43 | * number which is equal to the parent's number. | 44 | * number which is equal to the parent's number. |
| 44 | * | 45 | * |
| @@ -2601,6 +2602,17 @@ static int btrfsic_check_all_ref_blocks(struct btrfsic_state *state, | |||
| 2601 | (unsigned long long)l->block_ref_to->dev_bytenr, | 2602 | (unsigned long long)l->block_ref_to->dev_bytenr, |
| 2602 | l->block_ref_to->mirror_num); | 2603 | l->block_ref_to->mirror_num); |
| 2603 | ret = -1; | 2604 | ret = -1; |
| 2605 | } else if (l->block_ref_to->iodone_w_error) { | ||
| 2606 | printk(KERN_INFO "btrfs: attempt to write superblock" | ||
| 2607 | " which references block %c @%llu (%s/%llu/%d)" | ||
| 2608 | " which has write error!\n", | ||
| 2609 | btrfsic_get_block_type(state, l->block_ref_to), | ||
| 2610 | (unsigned long long) | ||
| 2611 | l->block_ref_to->logical_bytenr, | ||
| 2612 | l->block_ref_to->dev_state->name, | ||
| 2613 | (unsigned long long)l->block_ref_to->dev_bytenr, | ||
| 2614 | l->block_ref_to->mirror_num); | ||
| 2615 | ret = -1; | ||
| 2604 | } else if (l->parent_generation != | 2616 | } else if (l->parent_generation != |
| 2605 | l->block_ref_to->generation && | 2617 | l->block_ref_to->generation && |
| 2606 | BTRFSIC_GENERATION_UNKNOWN != | 2618 | BTRFSIC_GENERATION_UNKNOWN != |
