aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2015-07-31 15:56:10 -0400
committerThomas Gleixner <tglx@linutronix.de>2015-08-01 02:07:22 -0400
commit625b86ad26ad35200adc34094c04e04672384735 (patch)
treea97d0af2f668f43a04c58e9c7f42cb3a93e3d6ee
parent88bd64628f4f170491b47b90d772a229b0082859 (diff)
m68k/irq: Prepare irq handlers for irq argument removal
The irq argument of most interrupt flow handlers is unused or merily used instead of a local variable. The handlers which need the irq argument can retrieve the irq number from the irq descriptor. Search and update was done with coccinelle and the invaluable help of Julia Lawall. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: linux-m68k@lists.linux-m68k.org
-rw-r--r--arch/m68k/coldfire/intc-5272.c4
-rw-r--r--arch/m68k/mac/oss.c6
-rw-r--r--arch/m68k/mac/psc.c3
3 files changed, 9 insertions, 4 deletions
diff --git a/arch/m68k/coldfire/intc-5272.c b/arch/m68k/coldfire/intc-5272.c
index d1e2fbad327c..47371de60427 100644
--- a/arch/m68k/coldfire/intc-5272.c
+++ b/arch/m68k/coldfire/intc-5272.c
@@ -143,8 +143,10 @@ static int intc_irq_set_type(struct irq_data *d, unsigned int type)
143 * We need to be careful with the masking/acking due to the side effects 143 * We need to be careful with the masking/acking due to the side effects
144 * of masking an interrupt. 144 * of masking an interrupt.
145 */ 145 */
146static void intc_external_irq(unsigned int irq, struct irq_desc *desc) 146static void intc_external_irq(unsigned int __irq, struct irq_desc *desc)
147{ 147{
148 unsigned int irq = irq_desc_get_irq(desc);
149
148 irq_desc_get_chip(desc)->irq_ack(&desc->irq_data); 150 irq_desc_get_chip(desc)->irq_ack(&desc->irq_data);
149 handle_simple_irq(irq, desc); 151 handle_simple_irq(irq, desc);
150} 152}
diff --git a/arch/m68k/mac/oss.c b/arch/m68k/mac/oss.c
index bb11dceed7ed..191610d97689 100644
--- a/arch/m68k/mac/oss.c
+++ b/arch/m68k/mac/oss.c
@@ -63,13 +63,15 @@ void __init oss_nubus_init(void)
63 * Handle miscellaneous OSS interrupts. 63 * Handle miscellaneous OSS interrupts.
64 */ 64 */
65 65
66static void oss_irq(unsigned int irq, struct irq_desc *desc) 66static void oss_irq(unsigned int __irq, struct irq_desc *desc)
67{ 67{
68 int events = oss->irq_pending & 68 int events = oss->irq_pending &
69 (OSS_IP_IOPSCC | OSS_IP_SCSI | OSS_IP_IOPISM); 69 (OSS_IP_IOPSCC | OSS_IP_SCSI | OSS_IP_IOPISM);
70 70
71#ifdef DEBUG_IRQS 71#ifdef DEBUG_IRQS
72 if ((console_loglevel == 10) && !(events & OSS_IP_SCSI)) { 72 if ((console_loglevel == 10) && !(events & OSS_IP_SCSI)) {
73 unsigned int irq = irq_desc_get_irq(desc);
74
73 printk("oss_irq: irq %u events = 0x%04X\n", irq, 75 printk("oss_irq: irq %u events = 0x%04X\n", irq,
74 (int) oss->irq_pending); 76 (int) oss->irq_pending);
75 } 77 }
diff --git a/arch/m68k/mac/psc.c b/arch/m68k/mac/psc.c
index 272dde481d17..3b9e302e7a37 100644
--- a/arch/m68k/mac/psc.c
+++ b/arch/m68k/mac/psc.c
@@ -113,9 +113,10 @@ void __init psc_init(void)
113 * PSC interrupt handler. It's a lot like the VIA interrupt handler. 113 * PSC interrupt handler. It's a lot like the VIA interrupt handler.
114 */ 114 */
115 115
116static void psc_irq(unsigned int irq, struct irq_desc *desc) 116static void psc_irq(unsigned int __irq, struct irq_desc *desc)
117{ 117{
118 unsigned int offset = (unsigned int)irq_desc_get_handler_data(desc); 118 unsigned int offset = (unsigned int)irq_desc_get_handler_data(desc);
119 unsigned int irq = irq_desc_get_irq(desc);
119 int pIFR = pIFRbase + offset; 120 int pIFR = pIFRbase + offset;
120 int pIER = pIERbase + offset; 121 int pIER = pIERbase + offset;
121 int irq_num; 122 int irq_num;