diff options
author | Shawn Lin <shawn.lin@rock-chips.com> | 2016-03-09 03:11:32 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2016-03-09 04:10:18 -0500 |
commit | 61cadcf46cfdb9f7eec70527968c2b91e9823786 (patch) | |
tree | 0f150c8bbba7b6a890c0cb8530d5448a0926ae35 | |
parent | 557b7ea34b9a10a5e13f4d7fd58ac965d801e3bd (diff) |
spi: rockchip: check requesting dma channel with EPROBE_DEFER
Let's defer probing the driver if the return value of
dma_request_slave_channel is ERR_PTR(-EPROBE_DEFER) instead
of disabling dma capability directly.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/spi/spi-rockchip.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index b6b8a0bb5b2f..795fd191faa7 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c | |||
@@ -730,8 +730,14 @@ static int rockchip_spi_probe(struct platform_device *pdev) | |||
730 | master->handle_err = rockchip_spi_handle_err; | 730 | master->handle_err = rockchip_spi_handle_err; |
731 | 731 | ||
732 | rs->dma_tx.ch = dma_request_slave_channel(rs->dev, "tx"); | 732 | rs->dma_tx.ch = dma_request_slave_channel(rs->dev, "tx"); |
733 | if (!rs->dma_tx.ch) | 733 | if (IS_ERR_OR_NULL(rs->dma_tx.ch)) { |
734 | /* Check tx to see if we need defer probing driver */ | ||
735 | if (PTR_ERR(rs->dma_tx.ch) == -EPROBE_DEFER) { | ||
736 | ret = -EPROBE_DEFER; | ||
737 | goto err_get_fifo_len; | ||
738 | } | ||
734 | dev_warn(rs->dev, "Failed to request TX DMA channel\n"); | 739 | dev_warn(rs->dev, "Failed to request TX DMA channel\n"); |
740 | } | ||
735 | 741 | ||
736 | rs->dma_rx.ch = dma_request_slave_channel(rs->dev, "rx"); | 742 | rs->dma_rx.ch = dma_request_slave_channel(rs->dev, "rx"); |
737 | if (!rs->dma_rx.ch) { | 743 | if (!rs->dma_rx.ch) { |