diff options
author | Bart Van Assche <bart.vanassche@sandisk.com> | 2017-01-11 14:57:17 -0500 |
---|---|---|
committer | Bart Van Assche <bart.vanassche@sandisk.com> | 2017-01-17 14:26:41 -0500 |
commit | 61778a1c5a4556da1a1e005d506f89f009031e62 (patch) | |
tree | 44c28bc0b3c1e58d32bb8e64306d4c72e7de9111 | |
parent | ca825828a5c797d431f6ec6a83c912787ffbb8af (diff) |
qla2xxx: Move two arrays from header files to .c files
This patch avoids that building with W=1 triggers compiler
warnings similar to the following:
drivers/scsi/qla2xxx/qla_nx2.h:538:23: warning: ‘qla8044_reg_tbl’ defined but not used [-Wunused-const-variable=]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: Quinn Tran <quinn.tran@qlogic.com>
Cc: Christoph Hellwig <hch@lst.de>
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx.c | 5 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx.h | 3 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx2.c | 17 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx2.h | 17 |
4 files changed, 23 insertions, 19 deletions
diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 54380b434b30..0a1723cc08cf 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c | |||
@@ -42,6 +42,11 @@ static int qla82xx_crb_table_initialized; | |||
42 | (crb_addr_xform[QLA82XX_HW_PX_MAP_CRB_##name] = \ | 42 | (crb_addr_xform[QLA82XX_HW_PX_MAP_CRB_##name] = \ |
43 | QLA82XX_HW_CRB_HUB_AGT_ADR_##name << 20) | 43 | QLA82XX_HW_CRB_HUB_AGT_ADR_##name << 20) |
44 | 44 | ||
45 | const int MD_MIU_TEST_AGT_RDDATA[] = { | ||
46 | 0x410000A8, 0x410000AC, | ||
47 | 0x410000B8, 0x410000BC | ||
48 | }; | ||
49 | |||
45 | static void qla82xx_crb_addr_transform_setup(void) | 50 | static void qla82xx_crb_addr_transform_setup(void) |
46 | { | 51 | { |
47 | qla82xx_crb_addr_transform(XDMA); | 52 | qla82xx_crb_addr_transform(XDMA); |
diff --git a/drivers/scsi/qla2xxx/qla_nx.h b/drivers/scsi/qla2xxx/qla_nx.h index 6201dce3553b..77624eac95a4 100644 --- a/drivers/scsi/qla2xxx/qla_nx.h +++ b/drivers/scsi/qla2xxx/qla_nx.h | |||
@@ -1176,8 +1176,7 @@ struct qla82xx_md_entry_queue { | |||
1176 | #define MD_MIU_TEST_AGT_ADDR_LO 0x41000094 | 1176 | #define MD_MIU_TEST_AGT_ADDR_LO 0x41000094 |
1177 | #define MD_MIU_TEST_AGT_ADDR_HI 0x41000098 | 1177 | #define MD_MIU_TEST_AGT_ADDR_HI 0x41000098 |
1178 | 1178 | ||
1179 | static const int MD_MIU_TEST_AGT_RDDATA[] = { 0x410000A8, 0x410000AC, | 1179 | extern const int MD_MIU_TEST_AGT_RDDATA[4]; |
1180 | 0x410000B8, 0x410000BC }; | ||
1181 | 1180 | ||
1182 | #define CRB_NIU_XG_PAUSE_CTL_P0 0x1 | 1181 | #define CRB_NIU_XG_PAUSE_CTL_P0 0x1 |
1183 | #define CRB_NIU_XG_PAUSE_CTL_P1 0x8 | 1182 | #define CRB_NIU_XG_PAUSE_CTL_P1 0x8 |
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index 007192d7bad8..dc1ec9b61027 100644 --- a/drivers/scsi/qla2xxx/qla_nx2.c +++ b/drivers/scsi/qla2xxx/qla_nx2.c | |||
@@ -15,6 +15,23 @@ | |||
15 | 15 | ||
16 | #define TIMEOUT_100_MS 100 | 16 | #define TIMEOUT_100_MS 100 |
17 | 17 | ||
18 | static const uint32_t qla8044_reg_tbl[] = { | ||
19 | QLA8044_PEG_HALT_STATUS1, | ||
20 | QLA8044_PEG_HALT_STATUS2, | ||
21 | QLA8044_PEG_ALIVE_COUNTER, | ||
22 | QLA8044_CRB_DRV_ACTIVE, | ||
23 | QLA8044_CRB_DEV_STATE, | ||
24 | QLA8044_CRB_DRV_STATE, | ||
25 | QLA8044_CRB_DRV_SCRATCH, | ||
26 | QLA8044_CRB_DEV_PART_INFO1, | ||
27 | QLA8044_CRB_IDC_VER_MAJOR, | ||
28 | QLA8044_FW_VER_MAJOR, | ||
29 | QLA8044_FW_VER_MINOR, | ||
30 | QLA8044_FW_VER_SUB, | ||
31 | QLA8044_CMDPEG_STATE, | ||
32 | QLA8044_ASIC_TEMP, | ||
33 | }; | ||
34 | |||
18 | /* 8044 Flash Read/Write functions */ | 35 | /* 8044 Flash Read/Write functions */ |
19 | uint32_t | 36 | uint32_t |
20 | qla8044_rd_reg(struct qla_hw_data *ha, ulong addr) | 37 | qla8044_rd_reg(struct qla_hw_data *ha, ulong addr) |
diff --git a/drivers/scsi/qla2xxx/qla_nx2.h b/drivers/scsi/qla2xxx/qla_nx2.h index 02fe3c4cdf55..83c1b7e17c80 100644 --- a/drivers/scsi/qla2xxx/qla_nx2.h +++ b/drivers/scsi/qla2xxx/qla_nx2.h | |||
@@ -535,23 +535,6 @@ enum qla_regs { | |||
535 | #define CRB_CMDPEG_CHECK_RETRY_COUNT 60 | 535 | #define CRB_CMDPEG_CHECK_RETRY_COUNT 60 |
536 | #define CRB_CMDPEG_CHECK_DELAY 500 | 536 | #define CRB_CMDPEG_CHECK_DELAY 500 |
537 | 537 | ||
538 | static const uint32_t qla8044_reg_tbl[] = { | ||
539 | QLA8044_PEG_HALT_STATUS1, | ||
540 | QLA8044_PEG_HALT_STATUS2, | ||
541 | QLA8044_PEG_ALIVE_COUNTER, | ||
542 | QLA8044_CRB_DRV_ACTIVE, | ||
543 | QLA8044_CRB_DEV_STATE, | ||
544 | QLA8044_CRB_DRV_STATE, | ||
545 | QLA8044_CRB_DRV_SCRATCH, | ||
546 | QLA8044_CRB_DEV_PART_INFO1, | ||
547 | QLA8044_CRB_IDC_VER_MAJOR, | ||
548 | QLA8044_FW_VER_MAJOR, | ||
549 | QLA8044_FW_VER_MINOR, | ||
550 | QLA8044_FW_VER_SUB, | ||
551 | QLA8044_CMDPEG_STATE, | ||
552 | QLA8044_ASIC_TEMP, | ||
553 | }; | ||
554 | |||
555 | /* MiniDump Structures */ | 538 | /* MiniDump Structures */ |
556 | 539 | ||
557 | /* Driver_code is for driver to write some info about the entry | 540 | /* Driver_code is for driver to write some info about the entry |