diff options
author | David S. Miller <davem@davemloft.net> | 2017-04-01 16:31:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-04-01 16:31:15 -0400 |
commit | 612307c6bebc0651cf36b6bf76249898f595fd64 (patch) | |
tree | 6b294dcd3806cce0bf1183c00248b02b7030cdfc | |
parent | 0989bd034a125cef29bd6351514d588fc616b39a (diff) | |
parent | 7d65f82954dadbbe7b6e1aec7e07ad17bc6d958b (diff) |
Merge tag 'mac80211-for-davem-2017-03-31' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211
Johannes Berg says:
====================
Two fixes:
* don't block netdev queues (indefinitely!) if mac80211
manages traffic queueing itself
* check wiphy registration before checking for ops
on resume, to avoid crash
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/mac80211/iface.c | 3 | ||||
-rw-r--r-- | net/wireless/sysfs.c | 10 |
2 files changed, 6 insertions, 7 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 40813dd3301c..5bb0c5012819 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c | |||
@@ -718,7 +718,8 @@ int ieee80211_do_open(struct wireless_dev *wdev, bool coming_up) | |||
718 | ieee80211_recalc_ps(local); | 718 | ieee80211_recalc_ps(local); |
719 | 719 | ||
720 | if (sdata->vif.type == NL80211_IFTYPE_MONITOR || | 720 | if (sdata->vif.type == NL80211_IFTYPE_MONITOR || |
721 | sdata->vif.type == NL80211_IFTYPE_AP_VLAN) { | 721 | sdata->vif.type == NL80211_IFTYPE_AP_VLAN || |
722 | local->ops->wake_tx_queue) { | ||
722 | /* XXX: for AP_VLAN, actually track AP queues */ | 723 | /* XXX: for AP_VLAN, actually track AP queues */ |
723 | netif_tx_start_all_queues(dev); | 724 | netif_tx_start_all_queues(dev); |
724 | } else if (dev) { | 725 | } else if (dev) { |
diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c index 16b6b5988be9..570a2b67ca10 100644 --- a/net/wireless/sysfs.c +++ b/net/wireless/sysfs.c | |||
@@ -132,12 +132,10 @@ static int wiphy_resume(struct device *dev) | |||
132 | /* Age scan results with time spent in suspend */ | 132 | /* Age scan results with time spent in suspend */ |
133 | cfg80211_bss_age(rdev, get_seconds() - rdev->suspend_at); | 133 | cfg80211_bss_age(rdev, get_seconds() - rdev->suspend_at); |
134 | 134 | ||
135 | if (rdev->ops->resume) { | 135 | rtnl_lock(); |
136 | rtnl_lock(); | 136 | if (rdev->wiphy.registered && rdev->ops->resume) |
137 | if (rdev->wiphy.registered) | 137 | ret = rdev_resume(rdev); |
138 | ret = rdev_resume(rdev); | 138 | rtnl_unlock(); |
139 | rtnl_unlock(); | ||
140 | } | ||
141 | 139 | ||
142 | return ret; | 140 | return ret; |
143 | } | 141 | } |