aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2017-11-19 15:14:53 -0500
committerDave Airlie <airlied@redhat.com>2017-11-19 15:14:53 -0500
commit5ee72d330fbefe069cc4a5faf9556b29fb5eb382 (patch)
treeddae085670e00a92832e0dde73cda4b7667c3b96
parent1220a3e5698238c9d5f75dbaacd3938b60048496 (diff)
parent9fd99f4f3f5e13ce959900ae57d64b1bdb51d823 (diff)
Merge tag 'drm-fsl-dcu-fixes-for-v4.15' of http://git.agner.ch/git/linux-drm-fsl-dcu into drm-next
Some cleanup/fixes, some noticed during testing of Noralf Trønnes rework of the suspend/resume helper. He will rebase the patchset ontop of this. * tag 'drm-fsl-dcu-fixes-for-v4.15' of http://git.agner.ch/git/linux-drm-fsl-dcu: drm/fsl-dcu: enable IRQ before drm_atomic_helper_resume() drm/fsl-dcu: avoid disabling pixel clock twice on suspend drm/fsl-dcu: Don't set connector DPMS property
-rw-r--r--drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c3
-rw-r--r--drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c5
2 files changed, 1 insertions, 7 deletions
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 58e9e0601a61..faf17b83b910 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -210,7 +210,6 @@ static int fsl_dcu_drm_pm_suspend(struct device *dev)
210 return PTR_ERR(fsl_dev->state); 210 return PTR_ERR(fsl_dev->state);
211 } 211 }
212 212
213 clk_disable_unprepare(fsl_dev->pix_clk);
214 clk_disable_unprepare(fsl_dev->clk); 213 clk_disable_unprepare(fsl_dev->clk);
215 214
216 return 0; 215 return 0;
@@ -233,6 +232,7 @@ static int fsl_dcu_drm_pm_resume(struct device *dev)
233 if (fsl_dev->tcon) 232 if (fsl_dev->tcon)
234 fsl_tcon_bypass_enable(fsl_dev->tcon); 233 fsl_tcon_bypass_enable(fsl_dev->tcon);
235 fsl_dcu_drm_init_planes(fsl_dev->drm); 234 fsl_dcu_drm_init_planes(fsl_dev->drm);
235 enable_irq(fsl_dev->irq);
236 drm_atomic_helper_resume(fsl_dev->drm, fsl_dev->state); 236 drm_atomic_helper_resume(fsl_dev->drm, fsl_dev->state);
237 237
238 console_lock(); 238 console_lock();
@@ -240,7 +240,6 @@ static int fsl_dcu_drm_pm_resume(struct device *dev)
240 console_unlock(); 240 console_unlock();
241 241
242 drm_kms_helper_poll_enable(fsl_dev->drm); 242 drm_kms_helper_poll_enable(fsl_dev->drm);
243 enable_irq(fsl_dev->irq);
244 243
245 return 0; 244 return 0;
246} 245}
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
index edd7d8127d19..c54806d08dd7 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
@@ -102,7 +102,6 @@ static int fsl_dcu_attach_panel(struct fsl_dcu_drm_device *fsl_dev,
102{ 102{
103 struct drm_encoder *encoder = &fsl_dev->encoder; 103 struct drm_encoder *encoder = &fsl_dev->encoder;
104 struct drm_connector *connector = &fsl_dev->connector.base; 104 struct drm_connector *connector = &fsl_dev->connector.base;
105 struct drm_mode_config *mode_config = &fsl_dev->drm->mode_config;
106 int ret; 105 int ret;
107 106
108 fsl_dev->connector.encoder = encoder; 107 fsl_dev->connector.encoder = encoder;
@@ -122,10 +121,6 @@ static int fsl_dcu_attach_panel(struct fsl_dcu_drm_device *fsl_dev,
122 if (ret < 0) 121 if (ret < 0)
123 goto err_sysfs; 122 goto err_sysfs;
124 123
125 drm_object_property_set_value(&connector->base,
126 mode_config->dpms_property,
127 DRM_MODE_DPMS_OFF);
128
129 ret = drm_panel_attach(panel, connector); 124 ret = drm_panel_attach(panel, connector);
130 if (ret) { 125 if (ret) {
131 dev_err(fsl_dev->dev, "failed to attach panel\n"); 126 dev_err(fsl_dev->dev, "failed to attach panel\n");