diff options
author | Joerg Roedel <jroedel@suse.de> | 2017-04-06 10:19:22 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-04-12 02:40:58 -0400 |
commit | 5ed386ec09a5d75bcf073967e55e895c2607a5c3 (patch) | |
tree | 34cd0b7760fe0a69880c4c3d29a030abbd463876 | |
parent | e5185a76a23b2d56fb2327ad8bd58fb1bcaa52b1 (diff) |
x86/mpx: Correctly report do_mpx_bt_fault() failures to user-space
When this function fails it just sends a SIGSEGV signal to
user-space using force_sig(). This signal is missing
essential information about the cause, e.g. the trap_nr or
an error code.
Fix this by propagating the error to the only caller of
mpx_handle_bd_fault(), do_bounds(), which sends the correct
SIGSEGV signal to the process.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: fe3d197f84319 ('x86, mpx: On-demand kernel allocation of bounds tables')
Link: http://lkml.kernel.org/r/1491488362-27198-1-git-send-email-joro@8bytes.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | arch/x86/mm/mpx.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c index cd44ae727df7..1c34b767c84c 100644 --- a/arch/x86/mm/mpx.c +++ b/arch/x86/mm/mpx.c | |||
@@ -526,15 +526,7 @@ int mpx_handle_bd_fault(void) | |||
526 | if (!kernel_managing_mpx_tables(current->mm)) | 526 | if (!kernel_managing_mpx_tables(current->mm)) |
527 | return -EINVAL; | 527 | return -EINVAL; |
528 | 528 | ||
529 | if (do_mpx_bt_fault()) { | 529 | return do_mpx_bt_fault(); |
530 | force_sig(SIGSEGV, current); | ||
531 | /* | ||
532 | * The force_sig() is essentially "handling" this | ||
533 | * exception, so we do not pass up the error | ||
534 | * from do_mpx_bt_fault(). | ||
535 | */ | ||
536 | } | ||
537 | return 0; | ||
538 | } | 530 | } |
539 | 531 | ||
540 | /* | 532 | /* |