diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2018-05-29 15:38:01 -0400 |
---|---|---|
committer | Helge Deller <deller@gmx.de> | 2018-06-28 11:14:44 -0400 |
commit | 5e791d2e4785f9ec7da4a02b9e8d00dace9e6917 (patch) | |
tree | 7c5fcbfc4e7525f9dd1a6fbc8464b3b9f9cf35af | |
parent | 1c971f39e62222d567f179ccaa1a186f1c203b52 (diff) |
parisc: Convert printk(KERN_LEVEL) to pr_lvl()
Convert printk(KERN_LEVEL) type of calls to pr_lvl() macros.
While here,
- convert printk() to pr_info()
- join back string literal to be on one line
- use %*phN (note, it gives 1 byte more for sake of simplicity)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Helge Deller <deller@gmx.de>
-rw-r--r-- | arch/parisc/kernel/drivers.c | 25 |
1 files changed, 9 insertions, 16 deletions
diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c index e0e1c9775c32..5eb979d04b90 100644 --- a/arch/parisc/kernel/drivers.c +++ b/arch/parisc/kernel/drivers.c | |||
@@ -154,17 +154,14 @@ int register_parisc_driver(struct parisc_driver *driver) | |||
154 | { | 154 | { |
155 | /* FIXME: we need this because apparently the sti | 155 | /* FIXME: we need this because apparently the sti |
156 | * driver can be registered twice */ | 156 | * driver can be registered twice */ |
157 | if(driver->drv.name) { | 157 | if (driver->drv.name) { |
158 | printk(KERN_WARNING | 158 | pr_warn("BUG: skipping previously registered driver %s\n", |
159 | "BUG: skipping previously registered driver %s\n", | 159 | driver->name); |
160 | driver->name); | ||
161 | return 1; | 160 | return 1; |
162 | } | 161 | } |
163 | 162 | ||
164 | if (!driver->probe) { | 163 | if (!driver->probe) { |
165 | printk(KERN_WARNING | 164 | pr_warn("BUG: driver %s has no probe routine\n", driver->name); |
166 | "BUG: driver %s has no probe routine\n", | ||
167 | driver->name); | ||
168 | return 1; | 165 | return 1; |
169 | } | 166 | } |
170 | 167 | ||
@@ -491,12 +488,9 @@ alloc_pa_dev(unsigned long hpa, struct hardware_path *mod_path) | |||
491 | 488 | ||
492 | dev = create_parisc_device(mod_path); | 489 | dev = create_parisc_device(mod_path); |
493 | if (dev->id.hw_type != HPHW_FAULTY) { | 490 | if (dev->id.hw_type != HPHW_FAULTY) { |
494 | printk(KERN_ERR "Two devices have hardware path [%s]. " | 491 | pr_err("Two devices have hardware path [%s]. IODC data for second device: %7phN\n" |
495 | "IODC data for second device: " | 492 | "Rearranging GSC cards sometimes helps\n", |
496 | "%02x%02x%02x%02x%02x%02x\n" | 493 | parisc_pathname(dev), iodc_data); |
497 | "Rearranging GSC cards sometimes helps\n", | ||
498 | parisc_pathname(dev), iodc_data[0], iodc_data[1], | ||
499 | iodc_data[3], iodc_data[4], iodc_data[5], iodc_data[6]); | ||
500 | return NULL; | 494 | return NULL; |
501 | } | 495 | } |
502 | 496 | ||
@@ -528,8 +522,7 @@ alloc_pa_dev(unsigned long hpa, struct hardware_path *mod_path) | |||
528 | * the keyboard controller | 522 | * the keyboard controller |
529 | */ | 523 | */ |
530 | if ((hpa & 0xfff) == 0 && insert_resource(&iomem_resource, &dev->hpa)) | 524 | if ((hpa & 0xfff) == 0 && insert_resource(&iomem_resource, &dev->hpa)) |
531 | printk("Unable to claim HPA %lx for device %s\n", | 525 | pr_warn("Unable to claim HPA %lx for device %s\n", hpa, name); |
532 | hpa, name); | ||
533 | 526 | ||
534 | return dev; | 527 | return dev; |
535 | } | 528 | } |
@@ -875,7 +868,7 @@ static void print_parisc_device(struct parisc_device *dev) | |||
875 | static int count; | 868 | static int count; |
876 | 869 | ||
877 | print_pa_hwpath(dev, hw_path); | 870 | print_pa_hwpath(dev, hw_path); |
878 | printk(KERN_INFO "%d. %s at 0x%px [%s] { %d, 0x%x, 0x%.3x, 0x%.5x }", | 871 | pr_info("%d. %s at 0x%px [%s] { %d, 0x%x, 0x%.3x, 0x%.5x }", |
879 | ++count, dev->name, (void*) dev->hpa.start, hw_path, dev->id.hw_type, | 872 | ++count, dev->name, (void*) dev->hpa.start, hw_path, dev->id.hw_type, |
880 | dev->id.hversion_rev, dev->id.hversion, dev->id.sversion); | 873 | dev->id.hversion_rev, dev->id.hversion, dev->id.sversion); |
881 | 874 | ||