diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-08-04 04:12:08 -0400 |
---|---|---|
committer | Doug Ledford <dledford@redhat.com> | 2017-08-04 15:09:56 -0400 |
commit | 5db465f235e74293e285e1fa924a55e52ba52a98 (patch) | |
tree | 9cca0d79c9da729f94ac883f163b9ed4c3732b70 | |
parent | 931b3c1a832621b4bdcbaf783096fc267eb36fbe (diff) |
IB/hns: checking for IS_ERR() instead of NULL
The hns_roce_v1_create_lp_qp() returns NULL on error, not error pointers.
Fixes: bfcc681bd09d ("IB/hns: Fix the bug when free mr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
-rw-r--r-- | drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index 23fad6d96944..2540b65e242c 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c | |||
@@ -733,7 +733,7 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev) | |||
733 | continue; | 733 | continue; |
734 | 734 | ||
735 | free_mr->mr_free_qp[i] = hns_roce_v1_create_lp_qp(hr_dev, pd); | 735 | free_mr->mr_free_qp[i] = hns_roce_v1_create_lp_qp(hr_dev, pd); |
736 | if (IS_ERR(free_mr->mr_free_qp[i])) { | 736 | if (!free_mr->mr_free_qp[i]) { |
737 | dev_err(dev, "Create loop qp failed!\n"); | 737 | dev_err(dev, "Create loop qp failed!\n"); |
738 | goto create_lp_qp_failed; | 738 | goto create_lp_qp_failed; |
739 | } | 739 | } |