aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Kershner <david.kershner@unisys.com>2015-09-04 12:01:29 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-09-13 12:43:40 -0400
commit5b12100a53c11ef760e78c2899be8f1bf33812ca (patch)
tree769e7d7983c10d110392d38d2c26f13c85953617
parentdd3afa57c515801f37071734f56be9035fdeaa8c (diff)
staging: unisys: unregister netdev when create debugfs fails
Noticed we were not unregistering the netdevice if we failed to create the debugfs entries. This patch fixes that problem. Signed-off-by: David Kershner <david.kershner@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/unisys/visornic/visornic_main.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 8c9da7ea7845..bacf1af4e8d4 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -1924,13 +1924,16 @@ static int visornic_probe(struct visor_device *dev)
1924 "%s debugfs_create_dir %s failed\n", 1924 "%s debugfs_create_dir %s failed\n",
1925 __func__, netdev->name); 1925 __func__, netdev->name);
1926 err = -ENOMEM; 1926 err = -ENOMEM;
1927 goto cleanup_xmit_cmdrsp; 1927 goto cleanup_register_netdev;
1928 } 1928 }
1929 1929
1930 dev_info(&dev->device, "%s success netdev=%s\n", 1930 dev_info(&dev->device, "%s success netdev=%s\n",
1931 __func__, netdev->name); 1931 __func__, netdev->name);
1932 return 0; 1932 return 0;
1933 1933
1934cleanup_register_netdev:
1935 unregister_netdev(netdev);
1936
1934cleanup_napi_add: 1937cleanup_napi_add:
1935 del_timer_sync(&devdata->irq_poll_timer); 1938 del_timer_sync(&devdata->irq_poll_timer);
1936 netif_napi_del(&devdata->napi); 1939 netif_napi_del(&devdata->napi);